All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: 최찬우 <cw00.choi@samsung.com>
Cc: alsa-devel@alsa-project.org, 박경민 <kyungmin.park@samsung.com>,
	심준영 <jy0922.shim@samsung.com>
Subject: Re: [PATCH] ASoC: SAMSUNG: Add Aquila sound driver
Date: Wed, 7 Jul 2010 22:36:44 +0900	[thread overview]
Message-ID: <20100707133642.GA11183@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4C343DBA.1040107@samsung.com>

On Wed, Jul 07, 2010 at 05:41:30PM +0900, 최찬우 wrote:

> +static const struct snd_kcontrol_new aquila_controls[] = {
> +};

This should be removed until there are controls to go in it.

> +static int aquila_wm8994_init(struct snd_soc_codec *codec)
> +{
> +	int ret;
> +	unsigned int reg;

It'd probably be useful to list any unconnected pins here (if there are
any) using snd_soc_nc_pin().

Otherwise this all looks very good - you should probably also include a
signoff from Mr. Shim, I guess.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2010-07-07 13:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07  8:41 [PATCH] ASoC: SAMSUNG: Add Aquila sound driver 최찬우
2010-07-07 13:36 ` Mark Brown [this message]
2010-07-08  1:51   ` 최찬우
  -- strict thread matches above, loose matches on Subject: below --
2010-07-08  4:57 Chanwoo Choi
2010-07-08  5:52 ` Jassi Brar
2010-07-08  8:10   ` Chanwoo Choi
2010-07-08  8:19     ` Jassi Brar
2010-07-09  1:06       ` Chanwoo Choi
2010-07-09  2:17         ` Jassi Brar
2010-07-08  7:05 ` Mark Brown
2010-07-09  2:21   ` Chanwoo Choi
2010-07-09  2:42     ` Mark Brown
2010-07-09  3:55       ` Chanwoo Choi
2010-07-12  7:23         ` Chanwoo Choi
2010-07-12  9:41           ` Mark Brown
2010-07-09  9:15       ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100707133642.GA11183@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cw00.choi@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.