From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Pavan Kumar Sunkara <pavan.sss1991@gmail.com>,
Petr Baudis <pasky@ucw.cz>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCHv2/RFC] gitweb: Prepare for splitting gitweb
Date: Thu, 8 Jul 2010 08:59:30 +0200 [thread overview]
Message-ID: <201007080859.33958.jnareb@gmail.com> (raw)
In-Reply-To: <7v39vustku.fsf@alter.siamese.dyndns.org>
Dnia czwartek 8. lipca 2010 02:30, Junio C Hamano napisał:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> >> > +install-modules:
> >> > + install_dirs=$(sort $(dir $(GITWEB_MODULES))) && \
> >> > ...
> >
> > For example with the following Makefile:
> >
> > GITWEB_MODULES += GitwebCache/SimpleFileCache.pm
> > GITWEB_MODULES += GitwebCache/Capture.pm
> > GITWEB_MODULES += GitwebCache/Capture/SelectFH.pm
> > GITWEB_MODULES += Gitweb/Config.pm
> >
> > all:
> > @echo $(sort $(dir $(GITWEB_MODULES)))
> >
> > running 'make' results in:
> >
> > Gitweb/ GitwebCache/ GitwebCache/Capture/
>
>
> Try replacing that with:
>
> all:
> install_dirs=$(sort $(dir $(GITWEB_MODULES))) && \
> echo $$install_dirs
>
> perhaps?
>
> Hint: dq.
You are completely right. I'm sorry. I should have copied the
structure from "[PATCH 2/2 v2] Makefile: work around ksh's failure to
handle missing list argument to for loop" more carefully.
I'll resend it.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-07-08 6:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 9:57 [PATCHv2/RFC] gitweb: Prepare for splitting gitweb Jakub Narebski
2010-07-07 10:30 ` Ævar Arnfjörð Bjarmason
2010-07-07 20:05 ` Jakub Narebski
2010-07-08 7:01 ` Jakub Narebski
2010-07-13 22:24 ` Jakub Narebski
2010-07-13 22:30 ` Ævar Arnfjörð Bjarmason
2010-07-14 9:24 ` Jakub Narebski
2010-07-14 10:05 ` Ævar Arnfjörð Bjarmason
2010-07-14 21:21 ` Jakub Narebski
2010-07-07 16:25 ` Junio C Hamano
2010-07-07 20:20 ` Jakub Narebski
2010-07-08 0:30 ` Junio C Hamano
2010-07-08 6:59 ` Jakub Narebski [this message]
2010-07-08 7:20 ` [PATCHv3/RFC] " Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007080859.33958.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.