From: Andrew Morton <akpm@linux-foundation.org>
To: Yusuke Goda <yusuke.goda.sx@renesas.com>
Cc: linux-mmc@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] tmio_mmc: Prevents unexpected status clear
Date: Thu, 8 Jul 2010 14:46:26 -0700 [thread overview]
Message-ID: <20100708144626.2091f6c1.akpm@linux-foundation.org> (raw)
In-Reply-To: <4C33DF98.10409@renesas.com>
On Wed, 07 Jul 2010 10:59:52 +0900
Yusuke Goda <yusuke.goda.sx@renesas.com> wrote:
> This patch clears only necessary bit.
>
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> ---
> drivers/mmc/host/tmio_mmc.h | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> index 64f7d5d..7944604 100644
> --- a/drivers/mmc/host/tmio_mmc.h
> +++ b/drivers/mmc/host/tmio_mmc.h
> @@ -82,10 +82,7 @@
>
> #define ack_mmc_irqs(host, i) \
> do { \
> - u32 mask;\
> - mask = sd_ctrl_read32((host), CTL_STATUS); \
> - mask &= ~((i) & TMIO_MASK_IRQ); \
> - sd_ctrl_write32((host), CTL_STATUS, mask); \
> + sd_ctrl_write32((host), CTL_STATUS, ~(i)); \
> } while (0)
Can we have a better changelog please?
What was wrong with the old code?
How does the patch fix it?
What are the user-visible runtime effects of the bug?
(It looks like that was a pretty gross bug - how did it pass testing??)
next prev parent reply other threads:[~2010-07-08 21:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 1:59 [PATCH] tmio_mmc: Prevents unexpected status clear Yusuke Goda
2010-07-08 21:46 ` Andrew Morton [this message]
2010-07-13 1:16 ` Yusuke Goda
2010-07-15 20:25 ` Andrew Morton
2010-08-25 22:11 ` Matt Fleming
2010-08-25 23:07 ` Andrew Morton
2010-08-26 0:53 ` Yusuke Goda
2010-08-26 6:53 ` Matt Fleming
2010-08-26 6:58 ` Magnus Damm
2010-08-26 7:26 ` Matt Fleming
2010-08-26 21:12 ` Andrew Morton
2010-08-26 22:10 ` Matt Fleming
2010-08-26 22:16 ` Andrew Morton
2010-08-26 22:30 ` Matt Fleming
2010-08-27 8:02 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708144626.2091f6c1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yusuke.goda.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.