From: Arnd Bergmann <arnd@arndb.de>
To: Stefan Assmann <sassmann@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
e1000-devel@lists.sourceforge.net, "Duyck,
Alexander H" <alexander.h.duyck@intel.com>,
gregory.v.rose@intel.com, jeffrey.t.kirsher@intel.com,
Andy Gospodarek <gospo@redhat.com>
Subject: Re: [PATCH] igbvf: avoid name clash between PF and VF
Date: Thu, 8 Jul 2010 15:41:57 +0200 [thread overview]
Message-ID: <201007081541.57685.arnd@arndb.de> (raw)
In-Reply-To: <4C2B0614.9040004@redhat.com>
On Wednesday 30 June 2010, Stefan Assmann wrote:
> diff --git a/drivers/net/igbvf/netdev.c b/drivers/net/igbvf/netdev.c
> index 5e2b2a8..2fb665b 100644
> --- a/drivers/net/igbvf/netdev.c
> +++ b/drivers/net/igbvf/netdev.c
> @@ -2787,7 +2787,7 @@ static int __devinit igbvf_probe(struct pci_dev *pdev,
> netif_carrier_off(netdev);
> netif_stop_queue(netdev);
>
> - strcpy(netdev->name, "eth%d");
> + strcpy(netdev->name, "veth%d");
> err = register_netdev(netdev);
> if (err)
> goto err_hw_init;
Note that 'veth' is the name used for a virtual ethernet pair by
drivers/net/veth.c. If a variant of your patch gets applied, it would
probably be useful to use a different naming scheme to avoid confusion
with the veth driver.
Arnd
next prev parent reply other threads:[~2010-07-08 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 8:53 [PATCH] igbvf: avoid name clash between PF and VF Stefan Assmann
2010-06-30 10:44 ` Ben Hutchings
2010-06-30 10:57 ` Stefan Assmann
2010-06-30 11:11 ` Kay Sievers
2010-06-30 13:07 ` Harald Hoyer
2010-06-30 16:59 ` Casey Leedom
2010-07-01 6:37 ` Stefan Assmann
2010-07-01 17:12 ` Casey Leedom
2010-07-02 6:37 ` Stefan Assmann
2010-07-08 13:41 ` Arnd Bergmann [this message]
2010-07-09 9:31 ` Stefan Assmann
2010-07-09 15:33 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007081541.57685.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alexander.h.duyck@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.