All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Eli Barzilay <eli@barzilay.org>
Cc: git@vger.kernel.org
Subject: Re: gitweb.perl suggestion
Date: Thu, 8 Jul 2010 21:01:40 +0200	[thread overview]
Message-ID: <201007082101.41286.jnareb@gmail.com> (raw)
In-Reply-To: <19510.3108.337932.666012@winooski.ccs.neu.edu>

Eli Barzilay wrote:
> On Jul  8, Jakub Narebski wrote:
> > 
> > So your proposed solution is good enough, but perhaps better would
> > be to leave 'action' unset if there is no parent info?  Then
> > dispatch would guess action, instead of doing it in less
> > sophisticated way in evaluate_path_info().
> 
> Ah, looking at the dispatch point, I see what you're talking about.
> But that sounds like a larger change to the code -- since it would
> probably lead to more default actions that get determined in dispatch
> instead of earlier.

I don't remember if it was the real reson why http://gitweb/project/<object>
defaults to 'shortlog' action, but <object> can be commit, but can be also
tag.  The 'shortlog' action makes sense for both... assuming that tag
points to a commit object, that is.

P.S. As usual, patches welcome...
-- 
Jakub Narebski
Poland

  reply	other threads:[~2010-07-08 19:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  2:38 gitweb.perl suggestion Eli Barzilay
2010-07-08 15:30 ` Jakub Narebski
2010-07-08 17:34   ` Eli Barzilay
2010-07-08 19:01     ` Jakub Narebski [this message]
2010-07-08 19:05       ` Eli Barzilay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007082101.41286.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=eli@barzilay.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.