From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1OX915-0006iI-ND for linux-mtd@lists.infradead.org; Fri, 09 Jul 2010 08:33:04 +0000 Date: Fri, 9 Jul 2010 11:32:56 +0300 From: Tony Lindgren To: Sukumar Ghorai Subject: Re: [PATCH v6 0/3] omap3 nand: cleanup exiting platform related code Message-ID: <20100709083256.GI24913@atomide.com> References: <1278660308-8689-1-git-send-email-s-ghorai@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278660308-8689-1-git-send-email-s-ghorai@ti.com> Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Sukumar Ghorai [100709 10:19]: > The following set of patches applies on top of for-next branch. > http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git > Patches verified on: omap3430-SDP, omap3630-sdp, zoom3 and beagle board > > And these are the patches required to address the following input - > 1. The NAND driver needs to stop tinkering with the GPMC registers > The omap General Purpose Memory Controller (GPMC) registers are omap > specific, and not driver specific. Tinkering with these registers can > cause issues with the other devices on the GPMC. > > 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files > Passing hardcoded GPMC virtual addressess is sure way to mess up things. > This should all become unnecessary once the NAND drivers stops messing > with the GPMC registers directly. Looks good to me, thanks for doing this. One more request: Please repost this series one more time with linux-arm-kernel mailing list Cc'd. Then if no comments, I'll merge this series during the next merge window. Regards, Tony