From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] colibri-pxa3xx: add touchscreen support
Date: Fri, 9 Jul 2010 18:53:41 +0200 [thread overview]
Message-ID: <201007091853.41395.arnd@arndb.de> (raw)
In-Reply-To: <201007091847.59787.pieterg@gmx.com>
On Friday 09 July 2010, pieterg wrote:
> >
> > But doesn't the code still create both devices in /sys/devices/platform
> > then? AFAICT, there is no runtime probing support to make sure you only
> > register the device that is there.
>
> Yes, they both show up. But at least the do not conflict, and only the
> detected device will register an input device.
That's still putting the logic into the wrong place. If you have a way
to detect the hardware, that should be done before creating the device,
otherwise there is no point in having a platform device to start with
and you could just detect it in your module_init function.
Arnd
next prev parent reply other threads:[~2010-07-09 16:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 20:49 [PATCH v2 5/5] colibri-pxa3xx: add touchscreen support pieterg
2010-07-08 23:03 ` Marek Vasut
2010-07-09 7:03 ` pieterg
2010-07-09 13:32 ` Marek Vasut
2010-07-09 16:14 ` Arnd Bergmann
2010-07-09 16:47 ` pieterg
2010-07-09 16:53 ` Arnd Bergmann [this message]
2010-07-09 17:21 ` pieterg
2010-07-09 17:25 ` Arnd Bergmann
2010-07-09 7:18 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007091853.41395.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.