From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 1/2] musb: Kill board specific pinmux from driver file Date: Fri, 9 Jul 2010 12:03:32 -0700 Message-ID: <20100709190332.GA29601@kroah.com> References: <1278587095-16978-1-git-send-email-ajay.gupta@ti.com> <1278587095-16978-2-git-send-email-ajay.gupta@ti.com> <20100709081532.GH24913@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from kroah.org ([198.145.64.141]:60751 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753585Ab0GITFJ (ORCPT ); Fri, 9 Jul 2010 15:05:09 -0400 Content-Disposition: inline In-Reply-To: <20100709081532.GH24913@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Ajay Kumar Gupta , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, felipe.balbi@nokia.com, gregkh@suse.de, Anand Gadiyar On Fri, Jul 09, 2010 at 11:15:33AM +0300, Tony Lindgren wrote: > * Ajay Kumar Gupta [100708 13:59]: > > From: Anand Gadiyar > > > > This pin-muxing is best done in the board files. The driver should > > not do this explicitly. > > > > Also, this code causes a warning to be thrown when OMAP2430 and OMAP3/4 > > support are enabled in the same kernel. > > > > Signed-off-by: Anand Gadiyar > > Acked-by: Felipe Balbi > > Signed-off-by: Ajay Kumar Gupta > > Acked-by: Tony Lindgren Thanks, I've added this to the patch. greg k-h > > > --- > > drivers/usb/musb/omap2430.c | 6 ------ > > 1 files changed, 0 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c > > index e06d65e..2111a24 100644 > > --- a/drivers/usb/musb/omap2430.c > > +++ b/drivers/usb/musb/omap2430.c > > @@ -32,8 +32,6 @@ > > #include > > #include > > > > -#include > > - > > #include "musb_core.h" > > #include "omap2430.h" > > > > @@ -194,10 +192,6 @@ int __init musb_platform_init(struct musb *musb, void *board_data) > > u32 l; > > struct omap_musb_board_data *data = board_data; > > > > -#if defined(CONFIG_ARCH_OMAP2430) > > - omap_cfg_reg(AE5_2430_USB0HS_STP); > > -#endif > > - > > /* We require some kind of external transceiver, hooked > > * up through ULPI. TWL4030-family PMICs include one, > > * which needs a driver, drivers aren't always needed. > > -- > > 1.6.2.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html