From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Fri, 9 Jul 2010 21:07:41 +0200 Subject: [PATCH 2/2] pxa/spitz: Rework spitz In-Reply-To: <201006111752.08130.marek.vasut@gmail.com> References: <1276238740-10640-1-git-send-email-marek.vasut@gmail.com> <201006110852.45838.marek.vasut@gmail.com> <20100611143600.GA1307@ucw.cz> <201006111752.08130.marek.vasut@gmail.com> Message-ID: <20100709190741.GA1669@ucw.cz> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi! > > > > 1) Made every part modular, components are not built in if not > > > > selected. 2) Removed loads of preprocessor goo, mostly "#ifdef > > > > MACH_AKITA .... #endif" and similar code. The kernel size will grow by > > > > a few kb now, but the file is much more readable. > > > > 3) Reworked SD/CF power setting function and made it reentrant. > > > > > > > > Signed-off-by: Marek Vasut > > > > --- > > > > > > > > arch/arm/mach-pxa/include/mach/spitz.h | 2 - > > > > arch/arm/mach-pxa/spitz.c | 748 > > > > > > > > ++++++++++++++++++-------------- 2 files changed, 420 insertions(+), > > > > 330 deletions(-) > > > > > > Pavel, Eric, I tested this on metan's Z, could you give it a go ? > > > > quick test on 2.6.35-rc2 (of the 2nd version), and all seems > > well. What should I look for? > > Nothing, the functionality should be the same ... I just felt like it needs > rework, it was frustrating digging in it in the state it is in now. The way it > is now it's much easier to hack on it. There are still open issues: > > 1) CPUfreq on Zaurus is still broken. (doesn't work on other devices - causes > freezes) > 2) PCMCIA driver looses interrupts. (pcmcia-sharpsl needs rework) hda timeouts? > 3) We need driver for the CPU PMIC. (I already wrote it) Can you cc me on that one? That should fix the random segfaults, right? > 4) Weird mess on the LCD when using DMA (also happens on other devices) > > So we'll have at least another four following patches sometimes later. > > Pavel, can we get this in? Can I get your Ack and get this one applied? Thanks Sorry, I was busy... 2) mixes all kinds of things together -- it would be better to split such patches in future, but yes, it looks ok. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html