All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t3000 (ls-files -o): modernize style
Date: Sun, 11 Jul 2010 10:14:32 -0500	[thread overview]
Message-ID: <20100711151432.GA1781@burratino> (raw)
In-Reply-To: <m3d3uul8pd.fsf@localhost.localdomain>

Jakub Narebski wrote:

> ... I don't think it is really needed.  There isn't anything there
> that can fail, and there isn't anything there that produces any
> output.

I should clarify.  I wrote this patch as preparation to add some new
tests to the same script.  The new tests are not cooked yet, so I just
sent the trivial part; there certainly is no urgent reason to apply it
soon (though no reason I see not to apply it either).

A better explanation for the rationale would be "follow the modern
style to make the script more readable and set a good example for
future tests".

> BTW. do all sane shells that can be used to run test suite support
> '<<-' here-doc redirection operators?  Is it in POSIX?

Yes[1] and yes[2].

Thanks for looking it over.
Jonathan

[1] $ git grep -l -F -e '<<-EO' -e '<<-\EO' origin/maint -- t | wc -l
    13
[2] http://www.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_04

      parent reply	other threads:[~2010-07-11 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-11  4:20 [PATCH] t3000 (ls-files -o): modernize style Jonathan Nieder
2010-07-11  8:33 ` Jakub Narebski
2010-07-11  9:10   ` Ævar Arnfjörð Bjarmason
2010-07-11 15:14   ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100711151432.GA1781@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.