Re: [PATCH 2/2] MIPS: MTX-1: cleanup and comments

[Florian Fainelli <florian@openwrt.org>]

Le Sunday 11 July 2010 17:40:38, Bruno Randolf a écrit :
> Add some comments about mtx1_pci_idsel() and remove a dead block of old
> code.
> 
> Signed-off-by: Bruno Randolf <br1@einfach.org>

Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
>  arch/mips/alchemy/mtx-1/board_setup.c |   12 ++++--------
>  1 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/mips/alchemy/mtx-1/board_setup.c
> b/arch/mips/alchemy/mtx-1/board_setup.c index 52d883d..3cf2fa2 100644
> --- a/arch/mips/alchemy/mtx-1/board_setup.c
> +++ b/arch/mips/alchemy/mtx-1/board_setup.c
> @@ -105,14 +105,10 @@ void __init board_setup(void)
>  int
>  mtx1_pci_idsel(unsigned int devsel, int assert)
>  {
> -#define MTX_IDSEL_ONLY_0_AND_3 0
> -#if MTX_IDSEL_ONLY_0_AND_3
> -	if (devsel != 0 && devsel != 3) {
> -		printk(KERN_ERR "*** not 0 or 3\n");
> -		return 0;
> -	}
> -#endif
> -
> +	/* This function is only necessary to support a proprietary Cardbus
> +	 * adapter on the mtx-1 "singleboard" variant. It triggers a custom
> +	 * logic chip connected to EXT_IO3 (GPIO1) to suppress IDSEL signals.
> +	 */
>  	if (assert && devsel != 0)
>  		/* Suppress signal to Cardbus */
>  		alchemy_gpio_set_value(1, 0);	/* set EXT_IO3 OFF */