From: Christoph Hellwig <hch@infradead.org>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/4] writeback: harmonize writeback threads and tasks - 3
Date: Mon, 12 Jul 2010 11:33:16 -0400 [thread overview]
Message-ID: <20100712153316.GA26429@infradead.org> (raw)
In-Reply-To: <1278920994-2402-5-git-send-email-dedekind1@gmail.com>
On Mon, Jul 12, 2010 at 10:49:54AM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
> The write-back code mixes words "thread" and "task" for the
> same things - this is not a problem, but this is still an
> inconsistency which makes it a bit difficult to read the code.
> It is better to use term "thread" consistently everywhere.
>
> This patch amends commentaries and makes them refer the forker thread and the
> write-back threads as "threads", not "tasks".
A convention I tend to use and I've seen in various places is to always
use _task for the storage of the task_struct pointer, and thread
everywhere else. This especially helps with having foo_thread for the
actual thread and foo_task for a global variable keeping the
task_struct pointer.
next prev parent reply other threads:[~2010-07-12 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 7:49 [PATCH 0/4] writeback: minor cleanups Artem Bityutskiy
2010-07-12 7:49 ` [PATCH 1/4] writeback: weed out unneeded code Artem Bityutskiy
2010-07-12 7:49 ` [PATCH 2/4] writeback: harmonize writeback threads and tasks - 1 Artem Bityutskiy
2010-07-12 7:49 ` [PATCH 3/4] writeback: harmonize writeback threads and tasks - 2 Artem Bityutskiy
2010-07-12 7:49 ` [PATCH 4/4] writeback: harmonize writeback threads and tasks - 3 Artem Bityutskiy
2010-07-12 15:33 ` Christoph Hellwig [this message]
2010-07-13 14:30 ` Artem Bityutskiy
2010-07-12 15:11 ` [PATCH 0/3] writeback: more clean-ups and fixes Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712153316.GA26429@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.