From: "Török Edwin" <edwintorok@gmail.com>
To: Eric Paris <eparis@parisplace.org>
Cc: Russell Coker <russell@coker.com.au>, SE-Linux <selinux@tycho.nsa.gov>
Subject: Re: clamav RWX
Date: Mon, 12 Jul 2010 15:55:26 +0300 [thread overview]
Message-ID: <20100712155526.344eefdf@debian> (raw)
In-Reply-To: <AANLkTin7CS0jgjas9otPYwMh0CSqdIaMMQ72YhQaqdmT@mail.gmail.com>
On Mon, 12 Jul 2010 07:48:29 -0400
Eric Paris <eparis@parisplace.org> wrote:
> 2010/7/12 Török Edwin <edwintorok@gmail.com>:
>
> > [*]
> > I have some plans to make the JIT work without RWX, since ClamAV
> > has 2 phases:
> > - load DB, JIT compile bytecode (should use only RW- mapping, but
> > currently needs RWX)
> > - execute (JIT compiled) bytecode (should change mapping to be R-X)
>
> Just so you know that is going to require the same permissions.
> (Hopefully) The only way to get around the SELinux permissions is to
> have 2 separate mappings. Basically in really really rough sudo-code,
>
> file = open(filename, RWX);
> unlink(file);
> truncate(file, however big you need);
> exec_area = mmap(PROT_EXEC, file);
> write_area = mmap(PROT_WRITE, file);
>
> then do all of the writing to write_area and all of the executing in
> exec_area.
>
> http://people.redhat.com/drepper/selinux-mem.html
Yes I've seen that page, however that is not going to be so simple.
All the relocations are done assuming that the code will be executed
where you write it to (and all absolute jumps are generated the
same way).
Changing that would be a lot of work, and could introduce new bugs.
>
> Simply using mremap to change a mapping from PROT_WRITE to PROT_EXEC
> will cause the same problems as just doing it at the same time.
Then I'd better write a small testcase before converting LLVM to do
that.
IIRC I tried something like that and worked, but I could have done
something wrong. Will try again to be sure.
Is there a boolean (other than execmem) that would allow RW -> RX
mprotect()?
Why is the 2 mappings approach more secure though?
What I want is generate some code at runtime, execute it, then maybe
change it again, and execute that. Both do just that.
Best regards,
--Edwin
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2010-07-12 12:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 9:22 clamav RWX Russell Coker
2010-07-12 11:01 ` Török Edwin
2010-07-12 11:48 ` Eric Paris
2010-07-12 12:08 ` Russell Coker
2010-07-12 12:45 ` Török Edwin
2010-07-12 14:32 ` Martin Orr
2010-07-12 14:35 ` Török Edwin
2010-07-29 11:42 ` Martin Orr
2010-07-12 12:55 ` Török Edwin [this message]
2010-07-12 16:31 ` Stephen Smalley
2010-07-12 18:08 ` Török Edwin
2010-07-12 20:26 ` Stephen Smalley
2010-07-13 6:29 ` Török Edwin
2010-07-13 6:41 ` Russell Coker
2010-09-23 20:12 ` Török Edwin
2010-07-13 15:26 ` Stephen Smalley
2010-07-12 21:32 ` Russell Coker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712155526.344eefdf@debian \
--to=edwintorok@gmail.com \
--cc=eparis@parisplace.org \
--cc=russell@coker.com.au \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.