From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remove incorrect log write optimization
Date: Mon, 12 Jul 2010 12:04:50 -0400 [thread overview]
Message-ID: <20100712160450.GA2666@infradead.org> (raw)
In-Reply-To: <1278905400.7456.14.camel@doink>
On Sun, Jul 11, 2010 at 10:30:00PM -0500, Alex Elder wrote:
> On Mon, 2010-06-28 at 10:34 -0400, Christoph Hellwig wrote:
> > We do need a barrier for the first buffer of a split log write. Otherwise
> > we might incorrectly stamp the tail LSN into transactions in the first
> > block, or not flush data I/O before updating the inode size.
>
> I'm not sure whether "first block" means the one at the beginning
> of the log, or the one at the beginning of a split log write.
It means beginning of the split write. I can fix up the commit message
if you want.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-12 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 14:34 [PATCH] xfs: remove incorrect log write optimization Christoph Hellwig
2010-07-09 16:13 ` Christoph Hellwig
2010-07-12 3:30 ` Alex Elder
2010-07-12 16:04 ` Christoph Hellwig [this message]
2010-07-13 19:52 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712160450.GA2666@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.