From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: PIT: stop vpit before irq_routing freed
Date: Mon, 12 Jul 2010 14:54:37 -0300 [thread overview]
Message-ID: <20100712175437.GA8193@amt.cnet> (raw)
In-Reply-To: <4C383F74.4040606@cn.fujitsu.com>
On Sat, Jul 10, 2010 at 05:37:56PM +0800, Xiao Guangrong wrote:
> Fix:
> general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
> ......
> Call Trace:
> [<ffffffffa0159bd1>] ? kvm_set_irq+0xdd/0x24b [kvm]
> [<ffffffff8106ea8b>] ? trace_hardirqs_off_caller+0x1f/0x10e
> [<ffffffff813ad17f>] ? sub_preempt_count+0xe/0xb6
> [<ffffffff8106d273>] ? put_lock_stats+0xe/0x27
> [<ffffffff8106e94b>] ? lock_release_holdtime+0x104/0x109
> [<ffffffff813ad214>] ? sub_preempt_count+0xa3/0xb6
> [<ffffffffa017cdae>] pit_do_work+0x69/0xc8 [kvm]
> [<ffffffff8105a441>] worker_thread+0x28e/0x3b0
> [<ffffffff8105a3e5>] ? worker_thread+0x232/0x3b0
> [<ffffffffa017cd45>] ? pit_do_work+0x0/0xc8 [kvm]
> [<ffffffff8105eafe>] ? autoremove_wake_function+0x0/0x39
> [<ffffffff8105a1b3>] ? worker_thread+0x0/0x3b0
> [<ffffffff8105e571>] kthread+0x7f/0x87
> [<ffffffff810039d4>] kernel_thread_helper+0x4/0x10
> [<ffffffff81036370>] ? finish_task_switch+0x70/0xe4
> [<ffffffff813a9e89>] ? _raw_spin_unlock_irq+0x3b/0x58
> [<ffffffff813aa400>] ? restore_args+0x0/0x30
> [<ffffffff8105e4f2>] ? kthread+0x0/0x87
> [<ffffffff810039d0>] ? kernel_thread_helper+0x0/0x10
> Code: 24 e8 26 00 00 45 31 ed 3b 98 28 01 00 00 73 39 89 db 48 8d 95 40 ff ff ff 48 8b 84 d8 30 01 00 00 bb 0c 00 00 00 48 85 c0 74
> 1e <48> 8b 08 48 8d 70 e0 48 89 d7 41 ff c5 48 83 c2 30 0f 18 09 48
> RIP [<ffffffffa0159c72>] kvm_set_irq+0x17e/0x24b [kvm]
>
> This bug is triggered when guest is shutdown, is because we freed
> irq_routing before pit thread stopped
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Applied, thanks.
prev parent reply other threads:[~2010-07-12 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 9:37 [PATCH] KVM: PIT: stop vpit before irq_routing freed Xiao Guangrong
2010-07-12 17:54 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712175437.GA8193@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.