From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist(bug 9094491) - rev3
Date: Mon, 12 Jul 2010 11:21:18 -0700 [thread overview]
Message-ID: <20100712182117.GA12179@mail.oracle.com> (raw)
In-Reply-To: <1277272108-3160-1-git-send-email-srinivas.eeda@oracle.com>
On Tue, Jun 22, 2010 at 10:48:28PM -0700, Srinivas Eeda wrote:
> + if (!__dlm_lockres_unused) {
> + mlog(ML_ERROR, "found lockres %s:%.*s: in use after deref\n",
> + dlm->name, res->lockname.len, res->lockname.name);
> + __dlm_print_one_lock_resource(res);
> + BUG();
> + }
/build/jlbec/linux-2.6/working/fs/ocfs2/dlm/dlmthread.c: In function ?dlm_purge_lockres?:
/build/jlbec/linux-2.6/working/fs/ocfs2/dlm/dlmthread.c:203: warning: the address of ?__dlm_lockres_unused? will always evaluate as ?true?
Was this even tested? I'm leaving this patch out of 'fixes'
until corrected and tested.
Joel
--
"Reader, suppose you were and idiot. And suppose you were a member of
Congress. But I repeat myself."
- Mark Twain
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-07-12 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 5:48 [Ocfs2-devel] [PATCH 1/1] ocfs2 fix o2dlm dlm run purgelist(bug 9094491) - rev3 Srinivas Eeda
2010-06-23 17:00 ` Sunil Mushran
2010-06-23 17:25 ` Srinivas Eeda
2010-06-26 10:42 ` Wengang Wang
2010-07-12 18:21 ` Joel Becker [this message]
2010-07-12 22:24 ` Srinivas Eeda
-- strict thread matches above, loose matches on Subject: below --
2010-07-12 22:16 Srinivas Eeda
2010-07-12 22:39 ` Joel Becker
2010-06-22 17:33 Srinivas Eeda
2010-06-22 23:22 ` Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712182117.GA12179@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.