From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: iproute, batch-cmds, and mac-vlans. Date: Mon, 12 Jul 2010 22:19:58 -0700 Message-ID: <20100712221958.2a87b0e3@nehalam> References: <4C3BF050.7040206@candelatech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: NetDev To: Ben Greear Return-path: Received: from mail.vyatta.com ([76.74.103.46]:47268 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540Ab0GMFUA (ORCPT ); Tue, 13 Jul 2010 01:20:00 -0400 In-Reply-To: <4C3BF050.7040206@candelatech.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 12 Jul 2010 21:49:20 -0700 Ben Greear wrote: > After too much time debugging, I finally realized that the ip > tool was truncating my command because the mac-vlan device name > had a '#' in it. > > ]# cat /tmp/foo.txt > ru add to 10.99.21.1 iif eth0#0 lookup local pref 11 > > > # IP tool has some hacked up debugging code > ]# ip -batch /tmp/foo.txt > argc: 4 > arg -:to:- > arg -:iif:- > WARNING: Using TABLE_MAIN in iprule_modify, table_ok: 0 cmd: 32 > > > So, it acts on eth0 instead of eth0#0, and silently ignores the 'lookup local pref 11'. > > I understand that it is trying to parse # as comments, but would you > all be interested in a patch that allowed ignoring '#' except > when it is the first non-whitespace character on a line, and maybe > when preceded by whitespace? This would of course have the possibility > of breaking someone's script somewhere, so it could be enabled with > a new command line arg, perhaps. Putting # in device name just sounds like a bad idea.