diff for duplicates of <201007122309063128435@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 14eaf7c..214fdc0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,12 +3,13 @@ Hi, by one in the following loop: entry = FIRST_ENTRY(bh); while (!IS_LAST_ENTRY(entry)) { - struct ext2_xattr_entry *next EXT2_XATTR_NEXT(entry); + struct ext2_xattr_entry *next = + EXT2_XATTR_NEXT(entry); if ((char *)next >= end) goto bad_block; - if (name_index = entry->e_name_index && - name_len = entry->e_name_len && - memcmp(name, entry->e_name, name_len) = 0) + if (name_index == entry->e_name_index && + name_len == entry->e_name_len && + memcmp(name, entry->e_name, name_len) == 0) goto found; entry = next; } @@ -35,7 +36,8 @@ index 0b94d61..a6bccdb 100644 } - /* Check the remaining name entries */ - while (!IS_LAST_ENTRY(entry)) { -- struct ext2_xattr_entry *next - EXT2_XATTR_NEXT(entry); +- struct ext2_xattr_entry *next = +- EXT2_XATTR_NEXT(entry); - if ((char *)next >= end) - goto bad_block; - entry = next; diff --git a/a/content_digest b/N1/content_digest index d7d9346..feff5c5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0crosslonelyover <crosslonelyover@gmail.com>\0" "Subject\0[PATCH] remove unnecesary while loop in ext2_xattr_get\0" - "Date\0Mon, 12 Jul 2010 15:09:09 +0000\0" + "Date\0Mon, 12 Jul 2010 23:09:09 +0800\0" "To\0linux-ext4 <linux-ext4@vger.kernel.org>" linux-kernel <linux-kernel@vger.kernel.org> " kernel-janitors <kernel-janitors@vger.kernel.org>\0" @@ -11,12 +11,13 @@ "by one in the following loop:\n" " entry = FIRST_ENTRY(bh);\n" " while (!IS_LAST_ENTRY(entry)) {\n" - " struct ext2_xattr_entry *next EXT2_XATTR_NEXT(entry);\n" + " struct ext2_xattr_entry *next =\n" + " EXT2_XATTR_NEXT(entry);\n" " if ((char *)next >= end)\n" " goto bad_block;\n" - " if (name_index = entry->e_name_index &&\n" - " name_len = entry->e_name_len &&\n" - " memcmp(name, entry->e_name, name_len) = 0)\n" + " if (name_index == entry->e_name_index &&\n" + " name_len == entry->e_name_len &&\n" + " memcmp(name, entry->e_name, name_len) == 0)\n" " goto found;\n" " entry = next;\n" " }\n" @@ -43,7 +44,8 @@ " \t}\n" "-\t/* Check the remaining name entries */\n" "-\twhile (!IS_LAST_ENTRY(entry)) {\n" - "-\t\tstruct ext2_xattr_entry *next -\t\t\tEXT2_XATTR_NEXT(entry);\n" + "-\t\tstruct ext2_xattr_entry *next =\n" + "-\t\t\tEXT2_XATTR_NEXT(entry);\n" "-\t\tif ((char *)next >= end)\n" "-\t\t\tgoto bad_block;\n" "-\t\tentry = next;\n" @@ -55,4 +57,4 @@ "-- \n" 1.7.1.1 -afae6fc29067038153335a190ecb5ecc08c13e07386298f696b5ed301af13d17 +f1f059a2c412c551685482357fcf04e847f9e18b050886e062928961e5e885eb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.