diff for duplicates of <20100713012506.GA30737@dastard> diff --git a/a/1.txt b/N1/1.txt index 58c40ff..57a8443 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,18 +2,18 @@ On Mon, Jul 12, 2010 at 06:08:51PM -0700, Patrick J. LoPresti wrote: > On Mon, Jul 12, 2010 at 5:21 PM, Andreas Dilger <adilger@dilger.ca> wrote: > > On 2010-07-11, at 11:04, Patrick J. LoPresti wrote: > > > -> >> + /* Absolute addressability check (borrowed from ext4/super.c) */ -> >> + if ((max_block > -> >> + (sector_t)(~0LL) >> (osb->sb->s_blocksize_bits - 9)) || -> >> + (max_block > (pgoff_t)(~0LL) >> (PAGE_CACHE_SHIFT - -> >> + osb->sb->s_blocksize_bits))) { -> >> + mlog(ML_ERROR, "Volume too large " -> >> + "to mount safely on this system"); -> >> + status = -EFBIG; -> >> + goto out; -> >> + } +> >> + ? ? /* Absolute addressability check (borrowed from ext4/super.c) */ +> >> + ? ? if ((max_block > +> >> + ? ? ? ? ?(sector_t)(~0LL) >> (osb->sb->s_blocksize_bits - 9)) || +> >> + ? ? ? ? (max_block > (pgoff_t)(~0LL) >> (PAGE_CACHE_SHIFT - +> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?osb->sb->s_blocksize_bits))) { +> >> + ? ? ? ? ? ? mlog(ML_ERROR, "Volume too large " +> >> + ? ? ? ? ? ? ? ? ?"to mount safely on this system"); +> >> + ? ? ? ? ? ? status = -EFBIG; +> >> + ? ? ? ? ? ? goto out; +> >> + ? ? } > > -> > This hunk of code is actually in several filesystems. It wouldn't be a bad idea to make it a library function that can be called by the filesystem to check the kernel page cache and block layer can handle these large filesystems. +> > This hunk of code is actually in several filesystems. ?It wouldn't be a bad idea to make it a library function that can be called by the filesystem to check the kernel page cache and block layer can handle these large filesystems. > > True, but some of them do it differently (e.g. see the #if switch in > xfs_sb_validate_fsb_count). Tracking down all variants and changing @@ -29,8 +29,4 @@ Cheers, Dave. -- Dave Chinner -david@fromorbit.com --- -To unsubscribe from this list: send the line "unsubscribe linux-ext4" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html +david at fromorbit.com diff --git a/a/content_digest b/N1/content_digest index 00020c2..5c0f84d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\03BB069D5-B193-43A4-B678-B3CEA4873B58@dilger.ca\0" "ref\0AANLkTikAEycm5PKTLPuRFcB0e4qNp5EuQbKUx5aruNrh@mail.gmail.com\0" "From\0Dave Chinner <david@fromorbit.com>\0" - "Subject\0Re: [PATCH 2/2] OCFS2: Allow huge (> 16 TiB) volumes to mount\0" + "Subject\0[Ocfs2-devel] [PATCH 2/2] OCFS2: Allow huge (> 16 TiB) volumes to mount\0" "Date\0Tue, 13 Jul 2010 11:25:06 +1000\0" "To\0Patrick J. LoPresti <lopresti@gmail.com>\0" "Cc\0Andreas Dilger <adilger@dilger.ca>" @@ -17,18 +17,18 @@ "> On Mon, Jul 12, 2010 at 5:21 PM, Andreas Dilger <adilger@dilger.ca> wrote:\n" "> > On 2010-07-11, at 11:04, Patrick J. LoPresti wrote:\n" "> > >\n" - "> >> + \302\240 \302\240 /* Absolute addressability check (borrowed from ext4/super.c) */\n" - "> >> + \302\240 \302\240 if ((max_block >\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240(sector_t)(~0LL) >> (osb->sb->s_blocksize_bits - 9)) ||\n" - "> >> + \302\240 \302\240 \302\240 \302\240 (max_block > (pgoff_t)(~0LL) >> (PAGE_CACHE_SHIFT -\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240osb->sb->s_blocksize_bits))) {\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 mlog(ML_ERROR, \"Volume too large \"\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240\"to mount safely on this system\");\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 status = -EFBIG;\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 goto out;\n" - "> >> + \302\240 \302\240 }\n" + "> >> + ? ? /* Absolute addressability check (borrowed from ext4/super.c) */\n" + "> >> + ? ? if ((max_block >\n" + "> >> + ? ? ? ? ?(sector_t)(~0LL) >> (osb->sb->s_blocksize_bits - 9)) ||\n" + "> >> + ? ? ? ? (max_block > (pgoff_t)(~0LL) >> (PAGE_CACHE_SHIFT -\n" + "> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?osb->sb->s_blocksize_bits))) {\n" + "> >> + ? ? ? ? ? ? mlog(ML_ERROR, \"Volume too large \"\n" + "> >> + ? ? ? ? ? ? ? ? ?\"to mount safely on this system\");\n" + "> >> + ? ? ? ? ? ? status = -EFBIG;\n" + "> >> + ? ? ? ? ? ? goto out;\n" + "> >> + ? ? }\n" "> >\n" - "> > This hunk of code is actually in several filesystems. \302\240It wouldn't be a bad idea to make it a library function that can be called by the filesystem to check the kernel page cache and block layer can handle these large filesystems.\n" + "> > This hunk of code is actually in several filesystems. ?It wouldn't be a bad idea to make it a library function that can be called by the filesystem to check the kernel page cache and block layer can handle these large filesystems.\n" "> \n" "> True, but some of them do it differently (e.g. see the #if switch in\n" "> xfs_sb_validate_fsb_count). Tracking down all variants and changing\n" @@ -44,10 +44,6 @@ "Dave.\n" "-- \n" "Dave Chinner\n" - "david@fromorbit.com\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + david at fromorbit.com -6c06eb677643454308dc355816bebe8a0a03052b876e608de1028d34f24fb9f4 +95e2e58dcffa648d4568e613430d1f1952fa5fd54e7744b462f1331a102a31c8
diff --git a/a/1.txt b/N2/1.txt index 58c40ff..93b2e64 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -30,7 +30,3 @@ Dave. -- Dave Chinner david@fromorbit.com --- -To unsubscribe from this list: send the line "unsubscribe linux-ext4" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 00020c2..caee4a5 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -44,10 +44,6 @@ "Dave.\n" "-- \n" "Dave Chinner\n" - "david@fromorbit.com\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + david@fromorbit.com -6c06eb677643454308dc355816bebe8a0a03052b876e608de1028d34f24fb9f4 +af52b076473de41ef278403e16c9ab3d73fca7ae9a00e442e02b051e86692d29
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.