From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH v2] ocfs2: Don't duplicate page passes i_size during CoW.
Date: Tue, 13 Jul 2010 01:13:07 -0700 [thread overview]
Message-ID: <20100713081306.GB31479@mail.oracle.com> (raw)
In-Reply-To: <1278991352-5540-1-git-send-email-tao.ma@oracle.com>
On Tue, Jul 13, 2010 at 11:22:32AM +0800, Tao Ma wrote:
> + /*
> + * We only duplicate pages until we reach i_size.
> + * So trim 'end' to the boundary of that page.
> + */
> + if (end > i_size_read(context->inode))
> + end = ((i_size_read(context->inode) + PAGE_CACHE_SIZE - 1) >>
> + PAGE_CACHE_SHIFT) << PAGE_CACHE_SHIFT;
Just use PAGE_CACHE_ALIGN().
Joel
--
"Any man who is under 30, and is not a liberal, has not heart;
and any man who is over 30, and is not a conservative, has no brains."
- Sir Winston Churchill
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-07-13 8:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 7:19 [Ocfs2-devel] [PATCH] ocfs2: Don't duplicate page passes i_size during CoW Tao Ma
2010-07-12 9:14 ` Joel Becker
2010-07-13 3:22 ` [Ocfs2-devel] [PATCH v2] " Tao Ma
2010-07-13 8:13 ` Joel Becker [this message]
2010-07-13 8:15 ` Joel Becker
2010-07-13 14:25 ` Tao Ma
2010-07-13 18:38 ` Joel Becker
2010-07-14 0:29 ` Tao Ma
2010-07-14 3:19 ` [Ocfs2-devel] [PATCH v5] " Tao Ma
2010-07-15 1:15 ` tristan
2010-07-15 21:02 ` Joel Becker
2010-07-13 14:50 ` [Ocfs2-devel] [PATCH v3] " Tao Ma
2010-07-13 15:30 ` [Ocfs2-devel] [PATCH v4] " Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100713081306.GB31479@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.