diff for duplicates of <20100713113459.GI5658@bicker> diff --git a/a/1.txt b/N1/1.txt index e7974aa..b4f5cf2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ In root_nfs_name() it does the following: } sprintf(nfs_export_path, buf, cp); -In the original code if (strlen(buf) + strlen(cp) = NFS_MAXPATHLEN) +In the original code if (strlen(buf) + strlen(cp) == NFS_MAXPATHLEN) then the sprintf() would lead to an overflow. Generally the rest of the code assumes that the path can have NFS_MAXPATHLEN (1024) characters and a NULL terminator so the fix is to add space to the nfs_export_path[] diff --git a/a/content_digest b/N1/content_digest index 71d5c66..2e4c8d9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[patch] nfs: include space for the NULL in root path\0" - "Date\0Tue, 13 Jul 2010 11:34:59 +0000\0" + "Date\0Tue, 13 Jul 2010 13:34:59 +0200\0" "To\0Trond Myklebust <Trond.Myklebust@netapp.com>\0" "Cc\0linux-nfs@vger.kernel.org" " kernel-janitors@vger.kernel.org\0" @@ -14,7 +14,7 @@ " }\n" " sprintf(nfs_export_path, buf, cp);\n" "\n" - "In the original code if (strlen(buf) + strlen(cp) = NFS_MAXPATHLEN)\n" + "In the original code if (strlen(buf) + strlen(cp) == NFS_MAXPATHLEN)\n" "then the sprintf() would lead to an overflow. Generally the rest of the\n" "code assumes that the path can have NFS_MAXPATHLEN (1024) characters and\n" "a NULL terminator so the fix is to add space to the nfs_export_path[]\n" @@ -36,4 +36,4 @@ " /* NFS-related data */\n" static struct nfs_mount_data nfs_data __initdata = { 0, };/* NFS mount info */ -287fb1c160e91c827761f1426cec7dac2adef9be974b71da2a3016e23afe5c98 +f1688128b58090e8d1e63ae0310d089fd0a870a6734d095eb023a29c18677eb9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.