All of lore.kernel.org
 help / color / mirror / Atom feed
From: d.cristiani@idem-tech.it (Dylan Cristiani)
To: linux-arm-kernel@lists.infradead.org
Subject: linux 2.6.34 bug
Date: Tue, 13 Jul 2010 12:44:14 +0200	[thread overview]
Message-ID: <20100713124414.00001de9@unknown> (raw)
In-Reply-To: <AANLkTimhjwiBzJ5kIe3doYawlhw_XZgmE6ys2Yg-Ucl9@mail.gmail.com>

On Tue, 13 Jul 2010 09:50:56 +0800
Eric Miao <eric.y.miao@gmail.com> wrote:


> 
> It was my bad. Fixed updated as below. Dylan, please help review:
> 
>     [ARM] pxa: fix incorrect order of AC97 reset pin configs
> 
>     Reported-by: Dylan Cristiani <d.cristiani@idem-tech.it>
>     Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> 
> diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c
> index 0af3617..c059dac 100644
> --- a/arch/arm/mach-pxa/pxa27x.c
> +++ b/arch/arm/mach-pxa/pxa27x.c
> @@ -41,10 +41,10 @@ void pxa27x_clear_otgph(void)
>  EXPORT_SYMBOL(pxa27x_clear_otgph);
> 
>  static unsigned long ac97_reset_config[] = {
> -	GPIO95_AC97_nRESET,
> -	GPIO95_GPIO,
> -	GPIO113_AC97_nRESET,
>  	GPIO113_GPIO,
> +	GPIO113_AC97_nRESET,
> +	GPIO95_GPIO,
> +	GPIO95_AC97_nRESET,
>  };
> 
>  void pxa27x_assert_ac97reset(int reset_gpio, int on)

for me is ok: ACK!

      reply	other threads:[~2010-07-13 10:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100708173621.00003527@unknown>
2010-07-08 16:42 ` linux 2.6.34 bug Marek Vasut
2010-07-08 19:22   ` Uwe Kleine-König
2010-07-13  1:50   ` Eric Miao
2010-07-13 10:44     ` Dylan Cristiani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100713124414.00001de9@unknown \
    --to=d.cristiani@idem-tech.it \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.