All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Seungwhan Youn <sw.youn@samsung.com>
Cc: alsa-devel@alsa-project.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Seungwhan Youn <claude.youn@gmail.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/3] ASoC: multi-component - Modify to use common S3C I2S features
Date: Thu, 15 Jul 2010 10:32:21 +0100	[thread overview]
Message-ID: <20100715093220.GE23529@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1279184328-31746-2-git-send-email-sw.youn@samsung.com>

On Thu, Jul 15, 2010 at 05:58:47PM +0900, Seungwhan Youn wrote:

> +	i2s->base = S3C64XX_PA_IISV4;
> +

I'd really expect this to be being pulled from the resources for the
platform device for the DAI rather than hard coded into the driver.  If
we're going to start reorganising things like this and touching all the
drivers it'd seem better to go straight to doing that rather than
introducing this approach.

  parent reply	other threads:[~2010-07-15  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <git send-email --to alsa-devel@alsa-project.org --cc "Liam Girdwood <lrg@slimlogic.co.uk>
2010-07-15  8:58 ` [PATCH 1/3] ASoC: multi-component - Fix S3C compile error Seungwhan Youn
2010-07-15  8:58   ` [PATCH 2/3] ASoC: multi-component - Modify to use common S3C I2S features Seungwhan Youn
2010-07-15  8:58     ` [PATCH 3/3] ASoC: multi-component - Add to support AC97 codec driver on SMDK Seungwhan Youn
2010-07-15  9:34       ` Mark Brown
2010-07-15 11:21         ` Seungwhan Youn
2010-07-15  9:32     ` Mark Brown [this message]
2010-07-15 11:33       ` [PATCH 2/3] ASoC: multi-component - Modify to use common S3C I2S features Seungwhan Youn
2010-07-15 11:54         ` Mark Brown
2010-07-15 12:04           ` Seungwhan Youn
2010-07-15  9:59   ` [PATCH 1/3] ASoC: multi-component - Fix S3C compile error Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100715093220.GE23529@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=claude.youn@gmail.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=sw.youn@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.