From: Borislav Petkov <borislav.petkov@amd.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Stephan Wolf <stephan@letzte-bankreihe.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Herrmann3, Andreas" <Andreas.Herrmann3@amd.com>
Subject: Re: [PATCH] enable readback to get HPET working on ATI SB4x00, kernel 2.6.35_rc5
Date: Thu, 15 Jul 2010 12:02:58 +0200 [thread overview]
Message-ID: <20100715100258.GA20469@aftab> (raw)
In-Reply-To: <alpine.LFD.2.00.1007151011550.3321@localhost.localdomain>
From: Thomas Gleixner <tglx@linutronix.de>
Date: Thu, Jul 15, 2010 at 04:22:14AM -0400
> On Thu, 15 Jul 2010, Stephan Wolf wrote:
> > Am 14.07.2010 23:04, schrieb Thomas Gleixner:
> >
> > > +static void __init ati_hpet_bugs(int num, int slot, int func)
> > > +{
> > > +#ifdef CONFIG_HPET_TIMER
> > > + hpet_readback_cmp = 1;
> > > +#endif
> > > +}
> > > +
> > > #define QFLAG_APPLY_ONCE 0x1
> > > #define QFLAG_APPLIED 0x2
> > > #define QFLAG_DONE (QFLAG_APPLY_ONCE|QFLAG_APPLIED)
> > > @@ -220,6 +236,8 @@ static struct chipset early_qrk[] __init
> > > PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs },
> > > { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS,
> > > PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs_contd },
> > > + { PCI_VENDOR_ID_ATI, PCI_ANY_ID,
> > > + PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_hpet_bugs },
> > > {}
> >
> > Hi, the patch above solves the problem on my machine.
>
> Thanks for testing.
>
> Borislav, any opinion ?
Yep, good idea to match SMBus device class on ATI, cool. Quickly tested
on my SB700.
Acked-by: Borislav Petkov <borislav.petkov@amd.com>
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-07-15 10:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 15:55 [PATCH] enable readback to get HPET working on ATI SB4x00, kernel 2.6.35_rc5 Stephan Wolf
2010-07-14 16:13 ` Linus Torvalds
2010-07-14 16:40 ` Stephan Wolf
2010-07-14 18:11 ` Borislav Petkov
2010-07-14 18:17 ` Linus Torvalds
2010-07-14 18:32 ` Borislav Petkov
2010-07-14 21:04 ` Thomas Gleixner
2010-07-15 7:06 ` Stephan Wolf
2010-07-15 8:22 ` Thomas Gleixner
2010-07-15 10:02 ` Borislav Petkov [this message]
2010-07-15 15:12 ` [tip:x86/urgent] x86: Force HPET readback_cmp for all ATI chipsets tip-bot for Thomas Gleixner
2010-07-14 19:32 ` [PATCH] enable readback to get HPET working on ATI SB4x00, kernel 2.6.35_rc5 Thomas Gleixner
2010-07-14 19:30 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715100258.GA20469@aftab \
--to=borislav.petkov@amd.com \
--cc=Andreas.Herrmann3@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stephan@letzte-bankreihe.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.