From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/3] ASoC: multi-component - Modify to use common S3C I2S features Date: Thu, 15 Jul 2010 12:54:01 +0100 Message-ID: <20100715115401.GH23529@rakim.wolfsonmicro.main> References: <1279184328-31746-1-git-send-email-sw.youn@samsung.com> <1279184328-31746-2-git-send-email-sw.youn@samsung.com> <20100715093220.GE23529@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id B06E7245A4 for ; Thu, 15 Jul 2010 13:54:02 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Seungwhan Youn Cc: Jassi Brar , alsa-devel@alsa-project.org, Liam Girdwood , Seungwhan Youn List-Id: alsa-devel@alsa-project.org On Thu, Jul 15, 2010 at 08:33:28PM +0900, Seungwhan Youn wrote: > Does your comment means that 'i2s->base' get base address from the > resources for the platform device using 'platform_get_resources()'? Yes, exactly. > I'm doing on preparing that issue into another patch already (because > I think this patch is only for Liam's multi-comp, not for that issue). My comment was that since this patch is going so far towards doing the move to pulling the data from the platform device it'd make sense to just do that as part of this patch rather than introduce a temporary workaround. It's not really any extra effort and it's much nicer.