From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Dan Tian <Dan.Tian@Atheros.com>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Haijun Liu <Haijun.Liu@Atheros.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH 1/3] Add BT3 AMP device support, by Atheros Linux BT3 team.
Date: Thu, 15 Jul 2010 12:09:21 -0300 [thread overview]
Message-ID: <20100715150921.GA3188@vigoh> (raw)
In-Reply-To: <CDAFEDABF718A54BABD0DA5476695307CE881EC1@SHEXMB-01.global.atheros.com>
Hi Dan,
* Dan Tian <Dan.Tian@Atheros.com> [2010-07-15 15:37:32 +0800]:
> From 40cbfbf5c1bc9109364970956d9b6f74f5846c70 Mon Sep 17 00:00:00 2001
> From: Haijun.Liu <Haijun.Liu@Atheros.com>
> Date: Wed, 14 Jul 2010 22:50:56 +0800
> Subject: [PATCH 1/3] Add BT3 AMP device support, by Atheros Linux BT3 team.
>
>
> Signed-off-by: Haijun.Liu <Haijun.Liu@Atheros.com>
> ---
> include/net/bluetooth/hci.h | 342 +++++++++++++++++++-
> include/net/bluetooth/hci_core.h | 264 ++++++++++++++-
> net/bluetooth/cmtp/core.c | 1 +
> net/bluetooth/hci_conn.c | 201 +++++++++++-
> net/bluetooth/hci_core.c | 349 ++++++++++++++++++--
> net/bluetooth/hci_event.c | 698 +++++++++++++++++++++++++++++++++++++-
> 6 files changed, 1822 insertions(+), 33 deletions(-)
Could you split all your patches in little chunks? +1882 is very hard to
review. And please be more verbose on the commit message, it can help us
figure out what's happening.
--
Gustavo F. Padovan
http://padovan.org
next prev parent reply other threads:[~2010-07-15 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 7:37 [PATCH 1/3] Add BT3 AMP device support, by Atheros Linux BT3 team Dan Tian
2010-07-15 14:29 ` David Vrabel
2010-07-15 15:09 ` Gustavo F. Padovan [this message]
2010-07-15 18:43 ` Luis R. Rodriguez
2010-07-15 19:42 ` Gustavo F. Padovan
2010-07-16 2:02 ` Dan Tian
2010-07-16 2:14 ` Haijun Liu
2010-07-16 16:08 ` Marcel Holtmann
2010-07-20 2:24 ` Dan Tian
2010-07-18 0:04 ` Bastien Nocera
2010-07-18 2:00 ` Marcel Holtmann
2010-07-27 12:00 ` David Vrabel
2010-07-28 5:39 ` Haijun Liu
2010-08-02 14:39 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715150921.GA3188@vigoh \
--to=gustavo@padovan.org \
--cc=Dan.Tian@Atheros.com \
--cc=Haijun.Liu@Atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.