From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
James Bottomley <James.Bottomley@suse.de>
Cc: linux-pm@lists.linux-foundation.org, mark gross <markgross@thegnar.org>
Subject: Re: Warnings from PM QoS plist usage
Date: Thu, 15 Jul 2010 18:58:46 +0200 [thread overview]
Message-ID: <201007151858.47087.rjw@sisk.pl> (raw)
In-Reply-To: <20100715162811.GA17100@rakim.wolfsonmicro.main>
On Thursday, July 15, 2010, Mark Brown wrote:
> On Thu, Jul 15, 2010 at 08:12:58AM +0200, James Bottomley wrote:
> > On Wed, 2010-07-14 at 10:35 +0100, Mark Brown wrote:
>
> > > > I've not looked at the PM QoS code at all so I don't know what the
> > > > appropriate place to fix this is - do we perhaps want to fix the debug
> > > > code to cope with no locks? Looking at the plist.h code it seems fairly
> > > > clear that there's currently no expectation that users should use
> > > > _PLIST_INIT_HEAD() directly.
>
> > Sorry ... I just wasn't sure what it wanted without reading through the
> > plist code more ... and also that debug item is hidden by
> > CONFIG_DEBUG_RT_MUTEXES, which is why I couldn't enable it.
>
> Ah, yes - I missed the existing spinlock.
>
> > This should fix the warning.
>
> It does indeed - thanks!
>
> Tested-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Thanks for testing.
James, I hope it's appropriate to add your sign-off to the patch?
Rafael
next prev parent reply other threads:[~2010-07-15 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100714093510.GC5933@sirena.org.uk>
2010-07-14 9:35 ` Warnings from PM QoS plist usage Mark Brown
2010-07-15 6:12 ` James Bottomley
2010-07-15 16:28 ` Mark Brown
2010-07-15 16:58 ` Rafael J. Wysocki [this message]
2010-07-15 17:02 ` James Bottomley
2010-07-19 1:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007151858.47087.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=James.Bottomley@suse.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=markgross@thegnar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.