From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH 1/8] checkpoint: model ckpt_siginfo on signalfd_siginfo Date: Thu, 15 Jul 2010 17:55:46 -0700 Message-ID: <20100716005546.GA8572@us.ibm.com> References: <1279035864-10533-1-git-send-email-ntl@pobox.com> <1279035864-10533-2-git-send-email-ntl@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1279035864-10533-2-git-send-email-ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Nathan Lynch Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Nathan Lynch [ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org] wrote: | ckpt_siginfo doesn't cover all of the possible siginfo fields; the | current code overloads some fields (such as si_uid for si_overrun), | which is confusing. Signed-ness on some fields is not correct either. | | signalfd_siginfo is a straightforward format for representing siginfo, | so copy it and update the signal checkpoint code to use the new | fields. Although the ckpt_siginfo struct grows, there should be no | behavioral changes. | | Signed-off-by: Nathan Lynch Switching to the signalfd_siginfo style makes it more easier to maintain. So for all patches in this set: Reviewed-by: Sukadev Bhattiprolu