From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
Petr Baudis <pasky@ucw.cz>
Subject: Re: [PATCHv2 GSOC 07/11] gitweb: Create Gitweb::RepoConfig module
Date: Fri, 16 Jul 2010 14:11:59 +0200 [thread overview]
Message-ID: <201007161412.01931.jnareb@gmail.com> (raw)
In-Reply-To: <1279178951-23712-8-git-send-email-pavan.sss1991@gmail.com>
On Thu, 15 Jul 2010, Pavan Kumar Sunkara wrote:
> Create a Gitweb::RepoConfig module in 'gitweb/lib/Gitweb/RepoConfig.pm'
> to store and handle all the configuration and subroutines
> related to a single repository regarding the gitweb.perl script.
The above sentence is hard to parse (hard to understand). Please try
to be more clear. I guess that you wanted to say that this module
is about checking repositories and repository parameters, and about
per-repository configuration.
>
> This module depend on several other modules like Git.pm,
> Config.pm, Request.pm and Escape.pm.
Nitpick: the names of those modules are Gitweb::Git, Gitweb::Config,
Gitweb::Request and Gitweb::Escape.
>
> It also include subroutines regarding project_list and
> it's handling.
>
> Subroutines moved:
> check_head_link
> check_export_ok
> hash_set_multi
> git_parse_project_config
> config_to_bool
> config_to_int
> config_to_multi
> feature_bool
> feature_snapshot
> feature_patches
> feature_avatar
> git_get_project_config
> git_get_project_description
> git_get_project_ctags
> git_populate_project_tagcloud
> git_show_project_tagcloud
> git_get_project_url_list
> git_get_projects_list
> git_get_project_list_from_file
> git_get_project_owner
> get_file_owner
> project_in_list
In the future we might want to separate handling of per-repository
overriding of features in a separae module.
>
> Update gitweb/Makefile to install Gitweb::RepoConfig module
> alongside gitweb
>
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Other than those minor issues it seems all right.
P.S. I'm sorry, but I wouldn't be able to examine the rest of series
before this Sunday at earliest.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-07-16 12:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 7:29 [PATCHv2 00/11] Splitting gitweb Pavan Kumar Sunkara
2010-07-15 7:29 ` [PATCHv2 GSOC 01/11] gitweb: fix esc_url Pavan Kumar Sunkara
2010-07-15 13:52 ` Jakub Narebski
2010-07-15 18:57 ` Junio C Hamano
2010-07-15 19:32 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 02/11] gitweb: Prepare for splitting gitweb Pavan Kumar Sunkara
2010-07-15 18:05 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 03/11] gitweb: Create Gitweb::Git module Pavan Kumar Sunkara
2010-07-15 20:13 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 04/11] gitweb: Create Gitweb::Config module Pavan Kumar Sunkara
2010-07-15 21:21 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 05/11] gitweb: Create Gitweb::Request module Pavan Kumar Sunkara
2010-07-16 0:11 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 06/11] gitweb: Create Gitweb::Escape module Pavan Kumar Sunkara
2010-07-16 9:01 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 07/11] gitweb: Create Gitweb::RepoConfig module Pavan Kumar Sunkara
2010-07-16 12:11 ` Jakub Narebski [this message]
2010-07-15 7:29 ` [PATCHv2 GSOC 08/11] gitweb: Create Gitweb::View module Pavan Kumar Sunkara
2010-07-18 15:10 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 09/11] gitweb: Create Gitweb::Util module Pavan Kumar Sunkara
2010-07-18 17:45 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 10/11] gitweb: Create Gitweb::Format module Pavan Kumar Sunkara
2010-07-18 20:16 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 11/11] gitweb: Create Gitweb::Parse module Pavan Kumar Sunkara
2010-07-19 14:55 ` Jakub Narebski
2010-08-01 20:44 ` [PATCHv2 00/11] Splitting gitweb Sverre Rabbelier
2010-08-02 15:03 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007161412.01931.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.