From: Jonathan Nieder <jrnieder@gmail.com>
To: Ralf Thielow <ralf.thielow@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: remove duplicate code and not needed break statement
Date: Sun, 18 Jul 2010 13:47:16 -0500 [thread overview]
Message-ID: <20100718184716.GD14367@burratino> (raw)
In-Reply-To: <1279475399-6081-1-git-send-email-ralf.thielow@googlemail.com>
Hi Ralf!
Ralf Thielow wrote:
> Remove duplicate code and not needed break statement.
This looks like a reasonable change, with the nice effect of getting
read_pack_info_file() to almost fit in one screen.
The commit message is not super clear. I would say:
Subject: update-server-info: Shorten read_pack_info_file()
The correct responses to a D and a T line in .git/objects/info/packs
are the same, so combine their case arms. In both cases we already
‘goto’ out of the switch so while at it, remove a redundant ‘break’
to avoid yet another line of code.
i.e., impact in the subject line, details in the commit message body.
It is missing a sign-off. See Documentation/SubmittingPatches for
what that means.
Hope that helps,
Jonathan
next prev parent reply other threads:[~2010-07-18 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 17:49 remove duplicate code and not needed break statement Ralf Thielow
2010-07-18 17:57 ` Valeo de Vries
[not found] ` <AANLkTimuIBe2mvCH15D0RCzlgKTxhHEoX8KEsqiTJgO0@mail.gmail.com>
2010-07-18 18:19 ` Ralf Thielow
2010-07-18 18:29 ` Ralf Thielow
2010-07-18 18:47 ` Jonathan Nieder [this message]
2010-07-18 18:56 ` Ralf Thielow
2010-07-19 15:43 ` Erik Faye-Lund
2010-07-19 16:06 ` Jonathan Nieder
2010-07-19 16:26 ` Ralf Thielow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100718184716.GD14367@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=ralf.thielow@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.