From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>, Neil Brown <neilb@suse.de>
Cc: linux-nfs@vger.kernel.org
Subject: write_ports delfd case
Date: Mon, 19 Jul 2010 15:21:59 -0400 [thread overview]
Message-ID: <20100719192158.GC9657@fieldses.org> (raw)
Does anyone know what __write_ports_delfd() is meant to do?
The block comment above write_ports claims it handles writes of the form
"-<file descriptor>", which makes no sense (the file table of the writer
has nothing to do with anything). It's called only when the character
after the "-" is a digit, but the names it matches against (generated by
svc_one_sock_name()) start with "ipv4" or "ipv6".
I guess we should just rip out that case entirely? Or maybe I'm missing
something.
--b.
next reply other threads:[~2010-07-19 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 19:21 J. Bruce Fields [this message]
2010-07-19 19:32 ` write_ports delfd case Chuck Lever
2010-07-19 20:07 ` Jeff Layton
[not found] ` <20100719160703.1e686a74-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-07-19 23:41 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719192158.GC9657@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.