All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
	Yi Zou <yi.zou@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next-2.6 PATCH 4/5] ixgbe: use GFP_ATOMIC when allocating FCoE DDP context from the dma pool
Date: Mon, 19 Jul 2010 17:00:24 -0700	[thread overview]
Message-ID: <20100720000021.14112.63604.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100719235831.14112.14175.stgit@localhost.localdomain>

From: Yi Zou <yi.zou@intel.com>

The FCoE protocol stack may hold a lock when this gets called.

Signed-off-by: Yi Zou <yi.zou@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 drivers/net/ixgbe/ixgbe_fcoe.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_fcoe.c b/drivers/net/ixgbe/ixgbe_fcoe.c
index 1737d2b..072327c 100644
--- a/drivers/net/ixgbe/ixgbe_fcoe.c
+++ b/drivers/net/ixgbe/ixgbe_fcoe.c
@@ -190,7 +190,7 @@ int ixgbe_fcoe_ddp_get(struct net_device *netdev, u16 xid,
 	}
 
 	/* alloc the udl from our ddp pool */
-	ddp->udl = pci_pool_alloc(fcoe->pool, GFP_KERNEL, &ddp->udp);
+	ddp->udl = pci_pool_alloc(fcoe->pool, GFP_ATOMIC, &ddp->udp);
 	if (!ddp->udl) {
 		e_err(drv, "failed allocated ddp context\n");
 		goto out_noddp_unmap;


  parent reply	other threads:[~2010-07-20  0:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 23:59 [net-next-2.6 PATCH 1/5] ixgbe: dcb, set DPF bit when PFC is enabled Jeff Kirsher
2010-07-19 23:59 ` [net-next-2.6 PATCH 2/5] ixgbe: drop support for UDP in RSS hash generation Jeff Kirsher
2010-07-20  3:24   ` David Miller
2010-07-20  6:07     ` Bill Fink
2010-07-20  6:30       ` Eric Dumazet
2010-07-20  6:39         ` David Miller
2010-07-20  6:39   ` Eric Dumazet
2010-07-20  6:44     ` David Miller
2010-07-20 16:11     ` Alexander Duyck
2010-07-20 16:39       ` Eric Dumazet
2010-07-19 23:59 ` [net-next-2.6 PATCH 3/5] ixgbe: properly toggling netdev feature flags when disabling FCoE Jeff Kirsher
2010-07-20  3:24   ` David Miller
2010-07-20  0:00 ` Jeff Kirsher [this message]
2010-07-20  3:24   ` [net-next-2.6 PATCH 4/5] ixgbe: use GFP_ATOMIC when allocating FCoE DDP context from the dma pool David Miller
2010-07-20  0:00 ` [net-next-2.6 PATCH 5/5] ixgbe: fix version string for ixgbe Jeff Kirsher
2010-07-20  3:24   ` David Miller
2010-07-20  3:24 ` [net-next-2.6 PATCH 1/5] ixgbe: dcb, set DPF bit when PFC is enabled David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100720000021.14112.63604.stgit@localhost.localdomain \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=bphilips@novell.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=yi.zou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.