From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/6] xfs: remove obsolete osyncisosync mount option
Date: Tue, 20 Jul 2010 17:38:32 +1000 [thread overview]
Message-ID: <20100720073832.GH32635@dastard> (raw)
In-Reply-To: <20100718203926.229290039@bombadil.infradead.org>
On Sun, Jul 18, 2010 at 04:38:51PM -0400, Christoph Hellwig wrote:
> Since Linux 2.6.33 the kernel has support for real O_SYNC, which made
> the osyncisosync option a no-op. Warn the users about this and remove
> the mount flag for it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good, but I think these messages:
>
> @@ -366,9 +363,11 @@ xfs_parseargs(
> cmn_err(CE_WARN,
> "XFS: ihashsize no longer used, option is deprecated.");
> } else if (!strcmp(this_char, "osyncisdsync")) {
> - /* no-op, this is now the default */
> cmn_err(CE_WARN,
> - "XFS: osyncisdsync is now the default, option is deprecated.");
> + "XFS: the osyncisdsync option is deprecated as has no effect.");
> + } else if (!strcmp(this_char, "osyncisosync")) {
> + cmn_err(CE_WARN,
> + "XFS: the osyncisosync option is deprecated as has no effect.");
> } else if (!strcmp(this_char, "irixsgid")) {
> cmn_err(CE_WARN,
> "XFS: irixsgid is now a sysctl(2) variable, option is deprecated.");
Look better as:
"XFS: osyncisdsync has no effect, option is deprecated."
"XFS: osyncisosync has no effect, option is deprecated."
so they are consistent with the other deprecated option output.
I've made this change to the patch i have in my tree....
Otherwise,
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-20 7:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 20:38 [PATCH 0/6] a few cleanups for 2.6.36 Christoph Hellwig
2010-07-18 20:38 ` [PATCH 1/6] xfs: fix gcc 4.6 set but not read and unused statement warnings Christoph Hellwig
2010-07-20 7:34 ` Dave Chinner
2010-07-18 20:38 ` [PATCH 2/6] xfs: clean up filestreams helpers Christoph Hellwig
2010-07-20 7:35 ` Dave Chinner
2010-07-18 20:38 ` [PATCH 3/6] xfs: remove obsolete osyncisosync mount option Christoph Hellwig
2010-07-20 7:38 ` Dave Chinner [this message]
2010-07-20 8:09 ` Christoph Hellwig
2010-07-18 20:38 ` [PATCH 4/6] xfs: kill the b_strat callback in xfs_buf Christoph Hellwig
2010-07-20 7:41 ` Dave Chinner
2010-07-18 20:38 ` [PATCH 5/6] xfs: simplify xfs_truncate_file Christoph Hellwig
2010-07-20 7:44 ` Dave Chinner
2010-07-18 20:38 ` [PATCH 6/6] xfs: clean up xfs_bmap_get_bp Christoph Hellwig
2010-07-20 7:46 ` Dave Chinner
2010-07-20 7:50 ` [PATCH 0/6] a few cleanups for 2.6.36 Dave Chinner
2010-07-21 13:35 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720073832.GH32635@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.