From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758423Ab0GTMc2 (ORCPT ); Tue, 20 Jul 2010 08:32:28 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:34256 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755463Ab0GTMc1 (ORCPT ); Tue, 20 Jul 2010 08:32:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=raxAEFbXfxion1Ly5RxRRZzljegQTE7AZcBL/V9T7VD/N+gyw3R01ZOO8jzYGM0zLl iGMm5WrDcLZXIGcmo+jS8xUvZEWplXdoFznI3IJvrIojYTbv65Uy+pX+Y56H9MCw1to1 Ck3LJZk6FXq1hHCYDsLiH+O83knABkRyRy14A= Date: Tue, 20 Jul 2010 16:32:22 +0400 From: Anton Vorontsov To: Ben Hutchings Cc: David Woodhouse , Yulia Vilensky , Geert Stappers , LKML Subject: Re: [PATCH] ds2782_battery: Rename get_current and get_voltage operations Message-ID: <20100720123222.GA403@oksana.dev.rtsoft.ru> References: <1279584175.4883.226.camel@localhost> <20100720074659.GA32073@oksana.dev.rtsoft.ru> <1279619066.4883.249.camel@localhost> <20100720105712.GA20366@oksana.dev.rtsoft.ru> <20100720115019.GD3331@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20100720115019.GD3331@decadent.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2010 at 12:50:19PM +0100, Ben Hutchings wrote: > On Tue, Jul 20, 2010 at 02:57:12PM +0400, Anton Vorontsov wrote: > > On Tue, Jul 20, 2010 at 10:44:26AM +0100, Ben Hutchings wrote: > > > On Tue, 2010-07-20 at 11:46 +0400, Anton Vorontsov wrote: > > > > On Tue, Jul 20, 2010 at 01:02:55AM +0100, Ben Hutchings wrote: > > > > > commit 9b9ade6b612e562c4a5bd02ef38cc32e10f3f9ba "ds2782_battery: Add > > > > > support for ds2786 battery gas gauge" introduced an operation named > > > > > get_current. Since get_current() is defined as a macro on some > > > > > architectures this driver no longer compiles on those architectures. > > > > > > > > > > Rename get_current to get_current_now to avoid the macro. > > > > > Rename get_voltage to get_voltage_now for consistency. > > > > > > > > > > Reported-by: Geert Stappers > > > > > Signed-off-by: Ben Hutchings > > > > > --- > > > > > > > > Thanks for the patch, but I have a similar fix in the > > > > battery-2.6.git tree (for -next): > > > [...] > > > > > > This fix needs to go into 2.6.35. > > > > Did you read why I don't push it into 2.6.35? Reread my email, > > pay attention to the very bottom. > > It is a 2.6.35 regression; these operations were introduced in 2.6.35-rc1. > (Hint: use 'git describe --contains' not 'git describe'. Or even > 'git grep -w get_current v2.6.34:drivers/power/ds2782_battery.c'.) Oh, I got it. Will push, thanks! -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2