From: Florian Fainelli <florian@openwrt.org>
To: linux-mtd@lists.infradead.org
Cc: Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH] fix parallel build between ubi-utils and mkfs.ubifs
Date: Tue, 20 Jul 2010 15:24:39 +0200 [thread overview]
Message-ID: <201007201524.39147.florian@openwrt.org> (raw)
In-Reply-To: <1279595201-16520-1-git-send-email-vapier@gentoo.org>
Hi,
On Tuesday 20 July 2010 05:06:41 Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> Makefile | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b558705..8457654 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -9,6 +9,9 @@ endif
>
> SUBDIRS = lib ubi-utils mkfs.ubifs
>
> +# mkfs.ubifs needs -lubi which is in ubi-utils/
> +subdirs_mkfs.ubifs_all: subdirs_ubi-utils_all
> +
Do not you want this to be moved after include common.mk instead?
I had a build error with your patch, the version below works for me.
--
--- a/Makefile 2010-01-15 18:12:24.000000000 +0100
+++ b/Makefile 2010-07-20 15:23:02.000000000 +0200
@@ -22,6 +22,9 @@
include common.mk
+# mkfs.ubifs needs -lubi which is in ubi-utils/
+subdirs_mkfs.ubifs_all: subdirs_ubi-utils_all
+
clean::
-rm -f $(SYMLINKS)
ifneq ($(BUILDDIR)/.git,)
--
Florian
next prev parent reply other threads:[~2010-07-20 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 3:06 [PATCH] fix parallel build between ubi-utils and mkfs.ubifs Mike Frysinger
2010-07-20 13:24 ` Florian Fainelli [this message]
2010-07-20 21:27 ` [PATCH v2] " Mike Frysinger
2010-07-21 10:11 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007201524.39147.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.