From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/2] drm: allow drivers to provide their own EDID fetching routine Date: Tue, 20 Jul 2010 16:05:47 -0700 Message-ID: <20100720160547.5e73889c@virtuousgeek.org> References: <20100720154417.32091370@virtuousgeek.org> <1279666470.337.5.camel@clockmaker-el6> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1279666470.337.5.camel@clockmaker-el6> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, 21 Jul 2010 08:54:30 +1000 Dave Airlie wrote: > On Tue, 2010-07-20 at 15:44 -0700, Jesse Barnes wrote: > > Make drm_edid_read take a new argument, edid_read, to allow drivers to > > provide their own EDID fetch routine. Export the bit banging DDC over > > i2c version of the EDID fetching routine and make the drivers use it. > > This sets the stage for GMBUS support in the Intel driver. > > > > I think this needs some rework. > > You might want to checkout what the radeon driver does for hw i2c > engine. You should set up your own i2c hw handlers and use those instead > of bypassing the i2c stack. GMBUS is just another i2c hw block. I'll check it out, but I don't see what using the i2c stack buys us here except for obfuscation... -- Jesse Barnes, Intel Open Source Technology Center