From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ObFVA-0008P0-Ny for mharc-grub-devel@gnu.org; Tue, 20 Jul 2010 12:17:04 -0400 Received: from [140.186.70.92] (port=41433 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObFV6-0008OH-RO for grub-devel@gnu.org; Tue, 20 Jul 2010 12:17:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObFUs-0008Cd-SQ for grub-devel@gnu.org; Tue, 20 Jul 2010 12:16:47 -0400 Received: from smarthost01.mail.zen.net.uk ([212.23.3.140]:59935) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObFUs-0008CM-O8 for grub-devel@gnu.org; Tue, 20 Jul 2010 12:16:46 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost01.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1ObFUr-00049J-1j; Tue, 20 Jul 2010 16:16:45 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) id 1ObFUq-00022d-00; Tue, 20 Jul 2010 17:16:44 +0100 Date: Tue, 20 Jul 2010 17:16:43 +0100 From: Colin Watson To: The development of GNU GRUB Message-ID: <20100720161643.GR21862@riva.ucam.org> References: <201007090801.12986.vadic052@gmail.com> <20100711232621.GQ12396@riva.ucam.org> <20100712103815.GA10414@riva.ucam.org> <4C459E77.3090908@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4C459E77.3090908@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost01-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: 554790@bugs.debian.org, Vadim Solomin Subject: Re: Bug#554790: This breaks device.map on upgrade X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 16:17:02 -0000 On Tue, Jul 20, 2010 at 03:02:47PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 07/12/2010 12:38 PM, Colin Watson wrote: > >> Vladimir, would this patch need a copyright assignment? Most of it > >> seems pretty straightforward; in fact I doubt that it would come out > >> very much different if I'd written it from scratch. > > No need of copyright assignment for this patch. > > > 2010-07-12 Vadim Solomin > > 2010-07-12 Colin Watson > > > > Generate device.map in something closer to the old ordering. > > > > * util/deviceiter.c (struct device): New declaration. > > (compare_file_names): Rename to ... > > (compare_devices): ... this. Sort by kernel name in preference > > to the stable by-id name, but keep the latter as a fallback > > comparison. Update header comment. > > (grub_util_iterate_devices) [__linux__]: Construct and sort an > > array of `struct device' rather than of plain file names. > > Go ahead. OK, committed. Thanks. -- Colin Watson [cjwatson@ubuntu.com]