From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH] mwl8k: correct/silence sparse warnings
Date: Tue, 20 Jul 2010 14:29:04 -0400 [thread overview]
Message-ID: <20100720182903.GA3468@tuxdriver.com> (raw)
In-Reply-To: <1279650123.3706.45.camel@jlt3.sipsolutions.net>
On Tue, Jul 20, 2010 at 08:22:03PM +0200, Johannes Berg wrote:
> On Tue, 2010-07-20 at 14:07 -0400, John W. Linville wrote:
>
> > off = le32_to_cpu(cmd->rxwrptr) & 0xffff;
> > - iowrite32(cpu_to_le32(priv->rxq[0].rxd_dma), priv->sram + off);
> > + iowrite32((__force __u32) cpu_to_le32(priv->rxq[0].rxd_dma),
> > + priv->sram + off);
>
> Those don't seem right, it looks more like somebody thought they needed
> to byteswap the iowrite because PCI(e) is little endian, and were wrong?
Yeah, I agree. I was going with the thought that "it's working, so
I guess it is right". But then, development was probably done on an
LE system...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-07-20 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 18:07 [PATCH] mwl8k: correct/silence sparse warnings John W. Linville
2010-07-20 18:22 ` Johannes Berg
2010-07-20 18:29 ` John W. Linville [this message]
2010-07-20 18:39 ` [PATCH v2] " John W. Linville
2010-07-20 18:53 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720182903.GA3468@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=buytenh@wantstofly.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.