All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg KH <greg@kroah.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] sysfs: Don't allow the creation of symlinks we can't remove
Date: Tue, 20 Jul 2010 13:13:34 -0700	[thread overview]
Message-ID: <20100720201334.GA11991@suse.de> (raw)
In-Reply-To: <20100719133451.0862ca62.akpm@linux-foundation.org>

On Mon, Jul 19, 2010 at 01:34:51PM -0700, Andrew Morton wrote:
> On Thu, 8 Jul 2010 16:06:01 -0700
> Greg KH <greg@kroah.com> wrote:
> 
> > On Thu, Jul 08, 2010 at 03:28:53PM -0700, Eric W. Biederman wrote:
> > > Greg KH <greg@kroah.com> writes:
> > > 
> > > > With this patch, how does the existing code fail as the drivers aren't
> > > > fixed up?
> > > >
> > > > I like this change, just worried it will cause problems if it gets into
> > > > .35, without your RFC patch.  Will it?
> > > 
> > > It don't expect this patch to be worse than where we are current at.
> > > Network devices are renamed, and come and go enough that both the
> > > mac80211_hwsim and the bnep driver are currently unusable with a
> > > failure only the rename and remove.
> > > 
> > > This patch simply moves the failure into creation where we are a little more
> > > prepared to deal with problems, and this patch is limited to mac80211_hwsim,
> > > bnep, and any hypothetically undiscovered other network devices that
> > > have the same problem.
> > > 
> > > mac80211_hwsim with just this patch becomes somewhat usable as it's primary
> > > network device gets registered and the module can be loaded and unloaded.  It
> > > just doesn't create the wlan0 and wlan1 interfaces for the wifi interfaces.
> > 
> > Fair enough, I've commited it now, let's see what happens :)
> 
> geethanks!
> 
> On the FC6 test box I have no networking.

Ick.

Eric, any ideas?


  reply	other threads:[~2010-07-20 20:24 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-16257-10286@https.bugzilla.kernel.org/>
     [not found] ` <20100621150826.762ac9f2.akpm@linux-foundation.org>
2010-06-21 22:22   ` [Bugme-new] [Bug 16257] New: sysfs changes break hwsim and bnep drivers Eric W. Biederman
2010-06-21 22:29     ` Greg KH
2010-06-21 22:55       ` Eric W. Biederman
2010-06-21 23:10         ` Greg KH
2010-06-22  0:05           ` Eric W. Biederman
2010-06-22  3:56             ` Greg KH
2010-07-08 16:31               ` [PATCH] sysfs: Don't allow the creation of symlinks we can't remove Eric W. Biederman
2010-07-08 16:37                 ` [RFC][PATCH] mac80211_hwsim: No parent is better than an illegimate one Eric W. Biederman
2010-07-12  6:46                   ` Johannes Berg
2010-07-12 14:23                     ` Eric W. Biederman
2010-07-12 14:29                       ` Johannes Berg
2010-07-08 21:19                 ` [PATCH] sysfs: Don't allow the creation of symlinks we can't remove Greg KH
2010-07-08 22:28                   ` Eric W. Biederman
2010-07-08 23:06                     ` Greg KH
2010-07-19 20:34                       ` Andrew Morton
2010-07-20 20:13                         ` Greg KH [this message]
2010-07-21  5:08                           ` [PATCH 0/2] Support untagged symlinks to tagged directories Eric W. Biederman
2010-07-21  5:10                             ` [PATCH 1/2] sysfs: sysfs_delete_link handle symlinks from untagged " Eric W. Biederman
2010-07-21  5:12                               ` [PATCH 2/2] sysfs: allow creating " Eric W. Biederman
2010-07-21 19:02                             ` [PATCH 0/2] Support untagged symlinks " Greg KH
2010-07-21 20:20                               ` Eric W. Biederman
2010-07-21 20:36                                 ` Greg KH
2010-07-22  9:16                             ` [PATCH] Driver-core: Fix bluetooth network device rename regression Eric W. Biederman
2010-07-22 13:38                               ` Kay Sievers
2010-07-22 14:10                                 ` Johannes Berg
2010-07-22 15:30                                   ` Kay Sievers
2010-07-22 17:18                                 ` Eric W. Biederman
2010-07-22 17:44                                   ` Kay Sievers
2010-07-22 18:20                                     ` Johannes Berg
2010-07-22 18:28                                       ` Greg KH
2010-07-22 18:36                                         ` Johannes Berg
2010-07-22 18:54                                           ` Greg KH
2010-07-23  1:31                                             ` Eric W. Biederman
2010-07-26 18:09                                               ` Greg KH
2010-07-27  9:10                                                 ` Kay Sievers
2010-07-27 13:49                                                   ` Greg KH
2010-07-27 13:59                                                     ` Johannes Berg
2010-07-27 15:09                                                       ` Greg KH
2010-07-27 15:32                                                         ` Kay Sievers
2010-07-27 18:17                                                     ` Eric W. Biederman
2010-07-27 18:24                                                       ` Kay Sievers
2010-07-27 18:36                                                         ` Greg KH
2010-07-27 18:44                                                           ` Eric W. Biederman
2010-07-27 18:54                                                             ` Kay Sievers
2010-07-27 20:53                                                               ` Eric W. Biederman
2010-07-28  4:41                                                                 ` Kay Sievers
2010-07-28  5:12                                                                   ` Eric W. Biederman
2010-07-28  5:26                                                                     ` Kay Sievers
2010-07-28  7:57                                                                       ` Eric W. Biederman
2010-07-25  5:43                                             ` [PATCH] Driver-core: Always create class directories for classses that support namespaces Eric W. Biederman
2010-07-26 18:07                                               ` Greg KH
2010-07-22 23:03                                       ` [PATCH] Driver-core: Fix bluetooth network device rename regression Kay Sievers
2010-07-10 22:30                 ` [PATCH] sysfs: Don't allow the creation of symlinks we can't remove Maciej W. Rozycki
2010-07-22  9:54                 ` Johannes Berg
2010-07-22 10:05                   ` Eric W. Biederman
2010-07-22 10:10                     ` Johannes Berg
2010-07-22 10:35                       ` Eric W. Biederman
2010-07-22 10:41                         ` Johannes Berg
2010-07-22 11:27                           ` Eric W. Biederman
2010-07-22 11:30                             ` Johannes Berg
2010-07-08 16:55               ` [Bugme-new] [Bug 16257] New: sysfs changes break hwsim and bnep drivers Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100720201334.GA11991@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=greg@kroah.com \
    --cc=johannes@sipsolutions.net \
    --cc=kay.sievers@vrfy.org \
    --cc=macro@linux-mips.org \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.