From: Jared Hance <jaredhance@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Add test for git clean -e.
Date: Tue, 20 Jul 2010 19:35:54 -0400 [thread overview]
Message-ID: <20100720233554.GA2141@localhost.localdomain> (raw)
In-Reply-To: <7vmxtllwoi.fsf@alter.siamese.dyndns.org>
On Tue, Jul 20, 2010 at 01:34:21PM -0700, Junio C Hamano wrote:
> This is a good start but it doesn't seem to test possible interactions
> with entries in .gitignore file(s) in the working tree. Do we care?
Honestly, I'm not sure that we do care.
>
> What should happen when a path "path":
>
> (1) is marked to be ignored in .gitignore and -e "path" is also given;
It is excluded.
> (2) is marked not to be ignored (i.e. "!path") in .gitignore but -e
> "path" is given;
I think it would be good for "!path" to cause -e path to have no
effect because of globbing issues.
Currently, -e works as normal.
> (3) is marked to be ignored in .gitignore but -e "!path" is given;
Again, I'm not sure and am definately open to debate here. Personally,
I think that -e "!path" is completely abusing the use of -e, because
it is using -e to NOT exclude something.
Currently, -e has no effect.
> (4) is marked not to be ignored in .gitignore and -e "!path" is also
> given;
No effect happens. Again, this is abuse of -e in my opinion, as its
goal to allow one to do a clean and save one or two files.
> (5) perhaps other combinations like "!path" in a/.gitignore, and -e "a/path"
> from the command line.
Judging by (2), -e will work as normal.
next prev parent reply other threads:[~2010-07-20 23:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 19:35 [PATCH 0/2] Add -e/--exclude to git-clean Jared Hance
2010-07-20 19:35 ` [PATCH 1/2] " Jared Hance
2010-07-20 20:27 ` Junio C Hamano
2010-07-20 19:36 ` [PATCH 2/2] Add test for git clean -e Jared Hance
2010-07-20 20:34 ` Junio C Hamano
2010-07-20 23:35 ` Jared Hance [this message]
2010-07-20 19:43 ` [PATCH 0/2] Add -e/--exclude to git-clean Jared Hance
-- strict thread matches above, loose matches on Subject: below --
2010-07-19 18:39 [PATCH v3] Add --exclude " Jared Hance
2010-07-20 16:28 ` [PATCH/RFC v4 0/2] Add -e/--exclude to git clean Jared Hance
2010-07-20 16:30 ` [PATCH 2/2] Add test for git clean -e Jared Hance
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720233554.GA2141@localhost.localdomain \
--to=jaredhance@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.