From: Christoph Hellwig <hch@lst.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jes.Sorensen@redhat.com, Christoph Hellwig <hch@lst.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] Error on O_DIRECT for physical CDROM/DVD drives
Date: Wed, 21 Jul 2010 16:25:55 +0200 [thread overview]
Message-ID: <20100721142555.GA23320@lst.de> (raw)
In-Reply-To: <m3aapkc495.fsf@blackfin.pond.sub.org>
On Wed, Jul 21, 2010 at 04:13:10PM +0200, Markus Armbruster wrote:
> Agreed, but I figure Jes's fix is the best we can do for .13, and worth
> doing for .13.
As said in the previous mail it's incorrect in many ways. If at all
you could reject devices and files on filesysystems on device with
sector size > 512 bytes. But once that infrastructure is there fixing
it for real should be rather trivial. I'm looking into it now.
prev parent reply other threads:[~2010-07-21 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 7:45 [Qemu-devel] [PATCH v3] Error on O_DIRECT for physical CDROM/DVD drives Jes.Sorensen
2010-07-21 9:20 ` Markus Armbruster
2010-07-21 13:15 ` Christoph Hellwig
2010-07-21 14:13 ` Markus Armbruster
2010-07-21 14:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100721142555.GA23320@lst.de \
--to=hch@lst.de \
--cc=Jes.Sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.