[Qemu-devel] Re: [PATCH v3 2/2] monitor: Convert 'info qdm' to QMP

[Luiz Capitulino <lcapitulino@redhat.com>]

On Wed, 21 Jul 2010 18:51:19 +0100
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Wed, Jul 21, 2010 at 02:42:28PM -0300, Luiz Capitulino wrote:
> > On Mon, 19 Jul 2010 13:51:27 -0300
> > Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:
> > 
> > > Converts the 'info qdm' command to QMP, allowing the discovery of all devices
> > > known to the QEMU binary without relying on command line paramaters like
> > > -device ? and -device devtype,?
> > > 
> > > This change does not modify the output of the 'info qdm' monitor command.
> > > 
> > > Signed-off-by: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
> > > diff --git a/monitor.c b/monitor.c
> > > index 45fd482..66810f2 100644
> > > --- a/monitor.c
> > > +++ b/monitor.c
> > > @@ -2565,7 +2565,8 @@ static const mon_cmd_t info_cmds[] = {
> > >          .args_type  = "",
> > >          .params     = "",
> > >          .help       = "show qdev device model list",
> > > -        .mhandler.info = do_info_qdm,
> > > +        .user_print = do_info_qdm_print,
> > > +        .mhandler.info_new = do_info_qdm,
> > 
> > Haven't we agreed on calling this query-available-devices or something
> > like that?
> 
> That's getting rather verbose for a name ! How about just
> 'query-dev-types' (anticipating future query-netdev-types,
> query-chardev-types, commands etc, too)

I don't mind long names in the protocol, but I'm ok with your suggestion.