All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Stefan Sperling <stsp@elego.de>
Cc: "dev@subversion.apache.org" <dev@subversion.apache.org>,
	Bert Huijben <rhuijben@collab.net>,
	Daniel Shahaf <d.s@daniel.shahaf.name>,
	Will Palmer <wmpalmer@gmail.com>,
	David Michael Barr <david.barr@cordelta.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Sverre Rabbelier <srabbelier@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2] Add svnrdump
Date: Thu, 22 Jul 2010 00:33:24 +0530	[thread overview]
Message-ID: <20100721190324.GC23839@kytes> (raw)
In-Reply-To: <20100713201105.GN13310@ted.stsp.name>

Hi Stefan,

Stefan Sperling writes:
> Copy of what and when? This baton is global for the entire edit...
> 
> Going through the code, I see that you're using this to indicate to
> dump_node() whether an add_directory() or add_file() was in fact a copy.
> Why not remove this field from the struct and add it as a parameter to
> dump_node instead?

This is an excellent catch! It's in the editor baton for historical
reasons- cleaned up with my latest commit.

Thanks :)

-- Ram

      parent reply	other threads:[~2010-07-21 19:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-09 14:29 [PATCH v2] Add svnrdump Ramkumar Ramachandra
2010-07-13 20:11 ` Stefan Sperling
2010-07-14 15:32   ` Stefan Sperling
2010-07-14 16:01     ` Ramkumar Ramachandra
2010-07-14 16:48       ` C. Michael Pilato
2010-07-15 10:28         ` Ramkumar Ramachandra
2010-07-14 17:24       ` Stefan Sperling
2010-07-14 17:31         ` C. Michael Pilato
2010-07-14 17:34           ` Stefan Sperling
2010-07-14 17:47           ` Jonathan Nieder
2010-07-14 17:56             ` C. Michael Pilato
2010-07-15 12:01         ` Ramkumar Ramachandra
2010-07-14 19:25       ` Bert Huijben
2010-07-15 12:07         ` Ramkumar Ramachandra
2010-07-15 19:02   ` Ramkumar Ramachandra
2010-07-15 19:23     ` Stefan Sperling
2010-07-21 11:46       ` Ramkumar Ramachandra
2010-07-21 13:29         ` Daniel Shahaf
2010-07-21 19:03   ` Ramkumar Ramachandra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100721190324.GC23839@kytes \
    --to=artagnon@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=david.barr@cordelta.com \
    --cc=dev@subversion.apache.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=rhuijben@collab.net \
    --cc=srabbelier@gmail.com \
    --cc=stsp@elego.de \
    --cc=wmpalmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.