From: Nick Piggin <npiggin@suse.de>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Nick Piggin <npiggin@suse.de>,
Kristo Tero Tapani <tero.kristo@nokia.com>,
Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 11/11] writeback: prevent unnecessary bdi threads wakeups
Date: Thu, 22 Jul 2010 18:59:32 +1000 [thread overview]
Message-ID: <20100722085932.GA1254@amd> (raw)
In-Reply-To: <1279785739.3044.33.camel@localhost>
On Thu, Jul 22, 2010 at 11:02:19AM +0300, Artem Bityutskiy wrote:
> On Thu, 2010-07-22 at 18:05 +1000, Nick Piggin wrote:
> > I can see what you mean, but I think the designs in core code should
> > be made as efficient as possible _unless_ there is some complication
> > in doing otherwise (not the other way around).
> >
> > This is producing 2 unrequired context switches, so I really would
> > like to see it done properly. Setting up a timer is really pretty
> > simple (or if you would care to implement a delayed process wakeup
> > API, I think that would be useful -- I'm surprised there isn't one
> > already).
>
> OK, NP, I'll work on this.
Thanks.
> The only problem I see is that it will involve more maintainers and
> trees (I guess Ingo?), and make it even more difficult for me to reach
> upstream :-) But let's try and see!
I wouldn't worry about that. It's so simple that if you end up coding
the helper function to do a timer delayed wakeup, just send it to Jens
in your series, cc Ingo on it if you'd like.
next prev parent reply other threads:[~2010-07-22 8:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 9:31 [PATCHv2 00/16] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 01/11] writeback: harmonize writeback threads naming Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 02/11] writeback: fix possible race when creating bdi threads Artem Bityutskiy
2010-07-21 11:57 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 03/11] writeback: do not lose wake-ups in the forker thread - 1 Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 04/11] writeback: do not lose wake-ups in the forker thread - 2 Artem Bityutskiy
2010-07-21 11:57 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 05/11] writeback: do not lose wake-ups in bdi threads Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 06/11] writeback: simplify bdi code a little Artem Bityutskiy
2010-07-21 12:01 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 07/11] writeback: do not remove bdi from bdi_list Artem Bityutskiy
2010-07-21 12:02 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 08/11] writeback: move last_active to bdi Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 09/11] writeback: restructure bdi forker loop a little Artem Bityutskiy
2010-07-21 12:02 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 10/11] writeback: move bdi threads exiting logic to the forker thread Artem Bityutskiy
2010-07-21 12:04 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 11/11] writeback: prevent unnecessary bdi threads wakeups Artem Bityutskiy
2010-07-21 11:45 ` Artem Bityutskiy
2010-07-22 0:41 ` Dave Chinner
2010-07-22 6:50 ` Artem Bityutskiy
2010-07-22 6:50 ` Artem Bityutskiy
2010-07-22 9:00 ` Christoph Hellwig
2010-07-22 9:24 ` Artem Bityutskiy
2010-07-22 13:27 ` Artem Bityutskiy
2010-07-22 13:27 ` Artem Bityutskiy
2010-07-21 12:12 ` Christoph Hellwig
2010-07-22 3:19 ` Nick Piggin
2010-07-22 6:48 ` Artem Bityutskiy
2010-07-22 7:22 ` Tero.Kristo
2010-07-22 7:22 ` Tero.Kristo
2010-07-22 8:07 ` Nick Piggin
2010-07-22 8:05 ` Nick Piggin
2010-07-22 8:02 ` Artem Bityutskiy
2010-07-22 8:02 ` Artem Bityutskiy
2010-07-22 8:59 ` Nick Piggin [this message]
2010-07-22 9:50 ` Artem Bityutskiy
2010-07-22 9:50 ` Artem Bityutskiy
2010-07-23 15:03 ` Artem Bityutskiy
2010-07-23 15:03 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722085932.GA1254@amd \
--to=npiggin@suse.de \
--cc=axboe@kernel.dk \
--cc=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tero.kristo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.