From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] libxl: fix linking error Date: Thu, 22 Jul 2010 10:28:30 +0200 Message-ID: <201007221028.31235.Christoph.Egger@amd.com> References: <201007201824.30154.Christoph.Egger@amd.com> <19527.6331.710821.617543@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Wednesday 21 July 2010 18:14:14 Stefano Stabellini wrote: > On Wed, 21 Jul 2010, Ian Jackson wrote: > > Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"): > > > Attached patch fixes linking error when creating the xl binary. > > > The xl binary compiles in xl_cmdimpl.c which calls code from > > > libxl_paths.c and libxl_bootloader.c. > > > > ... > > > > > -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so > > > libxenlight.so +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o > > > libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so > > > > This can't possibly be right. Files called "libxl_*.o" are parts of > > libxl and should be in libxenlight.so. > > > > I see, however, that Stefano has already applied it. > > Yes, sorry I missed it. I realized this patch is wrong. Please apply the patch to correct this: http://lists.xensource.com/archives/html/xen-devel/2010-07/msg01068.html Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632