re: netfilter: nfnetlink_log: send complete hardware header

[Dan Carpenter <error27@gmail.com>]

Hi,

Smatch complains abbout 72961ecf84d67d6 "netfilter: nfnetlink_log: send
complete hardware header" which is net-next.
    
   462          if (indev && skb->dev) {
                             ^^^^^^^^
	skb->dev can be NULL here.

   463                  struct nfulnl_msg_packet_hw phw;
   464                  int len = dev_parse_header(skb, phw.hw_addr);
   465                  if (len > 0) {
   466                          phw.hw_addrlen = htons(len);
   467                          NLA_PUT(inst->skb, NFULA_HWADDR, sizeof(phw), &phw);
   468                  }
   469          }
   470  
   471          if (indev && skb_mac_header_was_set(skb)) {
   472                  NLA_PUT_BE16(inst->skb, NFULA_HWTYPE, htons(skb->dev->type));
                                                                    ^^^^^^^^
	It's dereferenced here.

   473                  NLA_PUT_BE16(inst->skb, NFULA_HWLEN,
   474                               htons(skb->dev->hard_header_len));

I'm not sure how you want to deal with this.

regards,
dan carpenter