From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: Jayamohan Kalickal <jayamohank@serverengines.com>
Cc: linux-scsi@vger.kernel.org, michaelc@cs.wisc.edu
Subject: Re: [PATCH 16/19] be2iscsi: Add support for iscsi boot
Date: Thu, 22 Jul 2010 13:37:56 -0400 [thread overview]
Message-ID: <201007221337.57465.konrad@kernel.org> (raw)
In-Reply-To: <20100721225908.GA9784@serverengines.com>
> +static ssize_t beiscsi_show_boot_eth_info(void *data, int type, char *buf)
> +{
> + struct beiscsi_hba *phba = data;
> + char *str = buf;
> + int rc;
> +
> + switch (type) {
> + case ISCSI_BOOT_ETH_FLAGS:
> + rc = sprintf(str, "2\n");
> + break;
> + case ISCSI_BOOT_ETH_INDEX:
> + rc = sprintf(str, "0\n");
Offset by one extra tab.
Otherwise it looks ok to me.
prev parent reply other threads:[~2010-07-23 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 22:59 [PATCH 16/19] be2iscsi: Add support for iscsi boot Jayamohan Kallickal
2010-07-22 17:37 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007221337.57465.konrad@kernel.org \
--to=konrad@kernel.org \
--cc=jayamohank@serverengines.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.