Re: [RFC][PATCH v1 06/15] perf: export tracepoint events via sysfs: iwlwifi and iwlwifi_io

[Dave Chinner <david@fromorbit.com>]

On Thu, Jul 22, 2010 at 10:14:00PM -0400, Steven Rostedt wrote:
> On Fri, 2010-07-23 at 11:37 +1000, Dave Chinner wrote:
> > On Thu, Jul 22, 2010 at 09:54:04AM -0400, Steven Rostedt wrote:
> > > On Thu, 2010-07-22 at 15:48 +0200, Ingo Molnar wrote:
> > > > * Steven Rostedt <rostedt@goodmis.org> wrote:
> > > 
> > > > Yeah - and the point of this submission is to allow the discussion of how to 
> > > > achieve these registrations.
> > > > 
> > > > Driver authors will want to have some control - for example the place where 
> > > > the events directory shows up in sysfs within the driver's directory structure 
> > > > - etc.
> > > > 
> > > > But we indeed want to automate it as much as possible.
> > > 
> > > Perhaps we can create a TRACE_EVENT_PATH() macro, that allows the
> > > developer to specify the path that the event will be seen in sysfs?
> > 
> > Perhaps you could build that into the event class definition as well
> > so each separate class in a subsystem can be placed in it's own
> > sub-directory?
> > 
> > That would make turning on and off specific classes trace points so
> > much simpler than it now, espcially for XFS where we now have > 250
> > tracepoints that are mostly defined by event classes already...
> 
> I was working on creating a "TRACE_CATEGORY()" that allowed you to put
> tracepoints into categories. Thus, these tracepoints will all still be
> in the XFS system, but you can add hierarchical categories that let you
> group and enable tracepoints in these groups.

Yes, that's pretty much what I was thinking of.

> But I stopped this work since it was more ftrace specific than perf, and
> I need to figure out how to continue my work on ftrace and at the same
> time merge it towards perf. This has been taking much longer than I have
> expected. Perhaps I should just finish that work, and then see how we
> can make perf work with it too?

I'm not fussed - it's more of a wishlist item right now. If it's in
the pipeline, then I'm happy to wait until you've done all the hard
work for me. ;)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com