From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50499 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcOjA-0007Ka-8d for qemu-devel@nongnu.org; Fri, 23 Jul 2010 16:20:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OcOj8-0006Nh-SU for qemu-devel@nongnu.org; Fri, 23 Jul 2010 16:20:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36177) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcOj8-0006N1-Kx for qemu-devel@nongnu.org; Fri, 23 Jul 2010 16:20:14 -0400 Date: Fri, 23 Jul 2010 17:20:05 -0300 From: Luiz Capitulino Message-ID: <20100723172005.5b9e680f@redhat.com> In-Reply-To: <1279903660-9607-1-git-send-email-miguel.filho@gmail.com> References: <1279903660-9607-1-git-send-email-miguel.filho@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v4 0/3] QMP: Introduce query-available-devices (was query-qdm) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miguel Di Ciurcio Filho Cc: avi@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Fri, 23 Jul 2010 13:47:37 -0300 Miguel Di Ciurcio Filho wrote: > This series introduces the documentation for the query-available-devices command > and the conversion of the monitor command 'info qdm' to QMP. > > The documentation and code were based on a patch previously sent to qemu-devel > by Daniel P. Berrange: > > http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg00931.html Looks good to me now, pushed it to the monitor queue. Only detail is that query-qdm was available and there was some unneeded blank lines, fixed both. > > Changelog from v3 > ----------------- > - Renamed the command from query-qdm to query-available-devices > - Fixed coding style when declaring the variable 'type' > - Fixed qlist leak in case the device does not have any property > - Split the series from 2 to 3 parts for easier review > > Changelog from v2 > ----------------- > - added IDE and s390-virtio as possible values for "bus" > - specify that the "properties" list is optional, in case the device doesn't > have anything to be setup > - reworded the explanation of "creatable" > - reverted the qdev/qmp split, just use "type" and its json equivalent > representation > - do not list legacy stuff: PROP_TYPE_(VLAN|PTR|UNSPEC) > > Changelog from v1 > ----------------- > - renamed "props" to "properties" > - updated the examples > - reworded the explanations of "name" and "description" > - split "type" into a json-object, adding "qmp" and "qdev" > - list all possible values for "bus" > - list all possible values for "qdev" on "type" > - list all possible values for "qmp" on "type" > > Changes from the Daniel's original patch: > - Split the patch in two, taking out the documentation from the code > - Reworded some parts of the documentation and added data types > - Small cleanups and renamed do_info_devices() to do_info_qdm() > - Added do_info_qdm_print() to be used in the monitor > > Regards, > > Miguel > > --- > > *** BLURB HERE *** > > Miguel Di Ciurcio Filho (3): > QMP: Introduce the documentation for query-available-devices > QMP: Introduce query-available-devices > monitor: Convert 'info qdm' to QMP > > hw/qdev.c | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++++- > hw/qdev.h | 3 +- > monitor.c | 11 +++++- > qemu-monitor.hx | 71 +++++++++++++++++++++++++++++++++++ > 4 files changed, 192 insertions(+), 4 deletions(-) >