From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] install udev rules into rules.d Date: Fri, 23 Jul 2010 20:20:48 +0200 Message-ID: <20100723182048.GB7603@aepfle.de> References: <20100723121634.GC3540@aepfle.de> <19529.51096.524315.988459@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <19529.51096.524315.988459@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Jul 23, Ian Jackson wrote: > Olaf Hering writes ("[Xen-devel] [PATCH] install udev rules into rules.d"): > > - $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR); \ > > - ln -sf ../$$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \ > > + $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \ > > What will this do if run on a system which already has the symlink > arrangement from the previous versions of Xen ? Perhaps some kind of > fixing up is necessary. I tried strace -f -o x -s 123 install a b, and b was unlinked first. So it appears that the patch above is save. Packing systems get this symlink-to-file thing right as well. Olaf